[libdazzle: 1/2] suggestion-entry: Call show-suggestion within set_model only
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libdazzle: 1/2] suggestion-entry: Call show-suggestion within set_model only
- Date: Tue, 30 Oct 2018 22:56:51 +0000 (UTC)
commit e0fdc179cf59fdf6d6568526f42ca5fff66b158e
Author: Jan-Michael Brummer <jan brummer tabos org>
Date: Fri Oct 26 22:41:54 2018 +0200
suggestion-entry: Call show-suggestion within set_model only
This removes the signal emitting from dzl_suggestion_entry_changed () in
order to remove unnecessary flickering during text input. The call is only
needed during dzl_suggesting_entry_set_model () for initial model setup.
Every further handling is done within dzl_suggestion_popover_items_changed ().
src/suggestions/dzl-suggestion-entry.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/suggestions/dzl-suggestion-entry.c b/src/suggestions/dzl-suggestion-entry.c
index 2089a30..f611798 100644
--- a/src/suggestions/dzl-suggestion-entry.c
+++ b/src/suggestions/dzl-suggestion-entry.c
@@ -271,8 +271,6 @@ dzl_suggestion_entry_changed (GtkEditable *editable)
DZL_GOTO (finish);
}
- g_signal_emit (self, signals [SHOW_SUGGESTIONS], 0);
-
suggestion = dzl_suggestion_popover_get_selected (priv->popover);
if (suggestion != NULL)
@@ -755,6 +753,8 @@ dzl_suggestion_entry_set_model (DzlSuggestionEntry *self,
dzl_suggestion_popover_set_model (priv->popover, model);
g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_MODEL]);
dzl_suggestion_entry_update_attrs (self);
+
+ g_signal_emit (self, signals [SHOW_SUGGESTIONS], 0);
}
DZL_EXIT;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]