[geary/wip/geary-inspector: 21/21] Fine tune Inspector filtering
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary/wip/geary-inspector: 21/21] Fine tune Inspector filtering
- Date: Sun, 7 Apr 2019 10:26:40 +0000 (UTC)
commit ba3e8034ecbb576c359ea0e48586fae82e296f33
Author: Michael Gratton <mike vee net>
Date: Sun Apr 7 18:22:00 2019 +1000
Fine tune Inspector filtering
Do a case-insensitive match, ignore empty strings, make matching words
conjunctive.
src/client/components/components-inspector.vala | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
---
diff --git a/src/client/components/components-inspector.vala b/src/client/components/components-inspector.vala
index 0785fa0a..152bbdfc 100644
--- a/src/client/components/components-inspector.vala
+++ b/src/client/components/components-inspector.vala
@@ -128,9 +128,10 @@ public class Components.Inspector : Gtk.ApplicationWindow {
int index = 0;
while (logs != null) {
if (should_append(logs)) {
+ string message = logs.format();
Gtk.TreeIter iter;
logs_store.insert(out iter, index++);
- logs_store.set_value(iter, COL_MESSAGE, logs.format());
+ logs_store.set_value(iter, COL_MESSAGE, message);
}
logs = logs.next;
}
@@ -139,14 +140,15 @@ public class Components.Inspector : Gtk.ApplicationWindow {
this.logs_filter.set_visible_func((model, iter) => {
bool ret = true;
if (this.logs_filter_terms.length > 0) {
- ret = false;
+ ret = true;
Value value;
model.get_value(iter, COL_MESSAGE, out value);
string? message = (string) value;
if (message != null) {
+ message = message.casefold();
foreach (string term in this.logs_filter_terms) {
- if (term in message) {
- ret = true;
+ if (!message.contains(term)) {
+ ret = false;
break;
}
}
@@ -270,7 +272,9 @@ public class Components.Inspector : Gtk.ApplicationWindow {
}
private void update_logs_filter() {
- this.logs_filter_terms = this.search_entry.text.split(" ");
+ string cleaned =
+ Geary.String.reduce_whitespace(this.search_entry.text).casefold();
+ this.logs_filter_terms = cleaned.split(" ");
this.logs_filter.refilter();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]