[gnome-builder] meson: warn if we didn't get a pty



commit 1e51f61006fb13dca80569ef64b9c77116202c15
Author: Christian Hergert <chergert redhat com>
Date:   Sat Apr 27 13:34:27 2019 -0700

    meson: warn if we didn't get a pty

 src/plugins/meson/gbp-meson-test-provider.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/src/plugins/meson/gbp-meson-test-provider.c b/src/plugins/meson/gbp-meson-test-provider.c
index b835a4306..619f80e23 100644
--- a/src/plugins/meson/gbp-meson-test-provider.c
+++ b/src/plugins/meson/gbp-meson-test-provider.c
@@ -454,8 +454,10 @@ gbp_meson_test_provider_run_build_cb (GObject      *object,
   g_assert (IDE_IS_TEST (run->test));
   g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
 
-  if (run->pty)
+  if (run->pty != NULL)
     ide_runner_set_pty (runner, run->pty);
+  else
+    g_critical ("Attempt to run unit test without a PTY");
 
   /* Default to running from builddir */
   builddir = ide_pipeline_get_builddir (pipeline);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]