[gnome-online-accounts/wip/rishi/daemon-add-account-missing-error: 2/2] identity: Remove redundant branch



commit 7f1447405c49b8b18ac657b03c6f2af54a4e2c71
Author: Debarshi Ray <debarshir gnome org>
Date:   Mon Aug 5 18:15:15 2019 +0200

    identity: Remove redundant branch
    
    An object path is guaranteed to be present if the AddAccount call to
    the daemon has succeeded.

 src/goaidentity/goaidentityservice.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/src/goaidentity/goaidentityservice.c b/src/goaidentity/goaidentityservice.c
index 98920664..a9ddae32 100644
--- a/src/goaidentity/goaidentityservice.c
+++ b/src/goaidentity/goaidentityservice.c
@@ -808,20 +808,16 @@ on_temporary_account_added (GoaManager   *manager,
       goto out;
     }
 
-  if (object_path != NULL && object_path[0] != '\0')
-    {
-      g_debug ("Created account for identity with object path %s", object_path);
+  g_debug ("Created account for identity with object path %s", object_path);
 
-      object_manager = goa_client_get_object_manager (self->priv->client);
-      object = GOA_OBJECT (g_dbus_object_manager_get_object (object_manager,
-                                                             object_path));
-      g_free (object_path);
-    }
+  object_manager = goa_client_get_object_manager (self->priv->client);
+  object = GOA_OBJECT (g_dbus_object_manager_get_object (object_manager, object_path));
 
   if (object != NULL)
     ensure_account_credentials (self, object);
 
  out:
+  g_free (object_path);
   g_clear_object (&object);
   g_object_unref (task);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]