[gnome-builder/gnome-builder-3-32] flatpak: do not propagate cancellable when installing runtimes
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/gnome-builder-3-32] flatpak: do not propagate cancellable when installing runtimes
- Date: Mon, 5 Aug 2019 20:05:39 +0000 (UTC)
commit 209a6236fe56da9d7648ecbff93dfc428d595ef4
Author: Christian Hergert <chergert redhat com>
Date: Sun Jun 30 10:56:40 2019 -0700
flatpak: do not propagate cancellable when installing runtimes
Related to #927
src/plugins/flatpak/gbp-flatpak-runtime-provider.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
b/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
index e101f3e43..f49ddb9b7 100644
--- a/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
+++ b/src/plugins/flatpak/gbp-flatpak-runtime-provider.c
@@ -781,8 +781,11 @@ gbp_flatpak_runtime_provider_bootstrap_async (IdeRuntimeProvider *provider,
}
else
{
+ /* Do not propagate cancellable to this operation or we risk cancelling
+ * in-flight operations that the user is expecting to complete.
+ */
gbp_flatpak_install_dialog_run_async (dialog,
- cancellable,
+ NULL,
gbp_flatpak_runtime_provider_bootstrap_cb,
g_object_ref (task));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]