[gnome-shell] environment: Fix transition callback
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] environment: Fix transition callback
- Date: Wed, 7 Aug 2019 16:06:27 +0000 (UTC)
commit 8b368d010f772fba123f198a5077d6778b76cae2
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Aug 7 02:26:32 2019 +0200
environment: Fix transition callback
This is rather embarrassing - we currently confuse the transition with
the finished parameter, which means we always run the onComplete handler
no matter whether the transition was interrupted or actually completed.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/668
js/ui/environment.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/environment.js b/js/ui/environment.js
index b00b74dd9..a248ea069 100644
--- a/js/ui/environment.js
+++ b/js/ui/environment.js
@@ -64,7 +64,7 @@ function _trackTransition(transition, callback) {
if (_easingTransitions.has(transition))
transition.disconnect(_easingTransitions.get(transition));
- let id = transition.connect('stopped', isFinished => {
+ let id = transition.connect('stopped', (t, isFinished) => {
_easingTransitions.delete(transition);
callback(isFinished);
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]