[gnome-shell/gbsneto/icon-grid-part2: 4/4] controlsManager: Don't fade icon grid while dragging

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 75c3694f2e14cbb15b7f8784c9fb9d9e3aba9f8b
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Wed Jul 3 14:53:09 2019 -0300

    controlsManager: Don't fade icon grid while dragging
    
    As pointed out by designers, fading it signals that the
    icon grid is not a drop target, when now it actually is.
    
    Remove the fade effect applied to the icon grid when
    dragging. Since this is the only caller of fadeIn() and
    fadeHalf(), also remove these methods.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/664

 js/ui/overviewControls.js | 11 -----------
 js/ui/viewSelector.js     | 18 ------------------
 2 files changed, 29 deletions(-)
---
diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index c9f9872c8..cf24a5e56 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -447,17 +447,6 @@ var ControlsManager = class {
         layout.connect('allocation-changed', this._updateWorkspacesGeometry.bind(this));
 
         Main.overview.connect('showing', this._updateSpacerVisibility.bind(this));
-        Main.overview.connect('item-drag-begin', () => {
-            let activePage = this.viewSelector.getActivePage();
-            if (activePage != ViewSelector.ViewPage.WINDOWS)
-                this.viewSelector.fadeHalf();
-        });
-        Main.overview.connect('item-drag-end', () => {
-            this.viewSelector.fadeIn();
-        });
-        Main.overview.connect('item-drag-cancelled', () => {
-            this.viewSelector.fadeIn();
-        });
     }
 
     _updateWorkspacesGeometry() {
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 9aef3b9dd..c4201239e 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -599,23 +599,5 @@ var ViewSelector = class {
         else
             return ViewPage.SEARCH;
     }
-
-    fadeIn() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 255,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_IN_QUAD
-        });
-    }
-
-    fadeHalf() {
-        let actor = this._activePage;
-        actor.ease({
-            opacity: 128,
-            duration: OverviewControls.SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_OUT_QUAD
-        });
-    }
 };
 Signals.addSignalMethods(ViewSelector.prototype);