[gjs: 42/43] CI: Add a rule to prevent accidentally switching off test cases



commit d94ac96c0265e0258e17c53d3c18b5d7b9cb1098
Author: Philip Chimento <philip chimento gmail com>
Date:   Tue Aug 13 22:16:50 2019 -0700

    CI: Add a rule to prevent accidentally switching off test cases
    
    During debugging, one can use fdescribe() or fit() to isolate a failing
    test case without having to run all the tests all the time, just by
    typing an 'f' (for 'focus'.)
    
    However, we should have a rule that will prevent the 'f' from being
    committed.

 installed-tests/js/.eslintrc.yml | 6 ++++++
 1 file changed, 6 insertions(+)
---
diff --git a/installed-tests/js/.eslintrc.yml b/installed-tests/js/.eslintrc.yml
index 3358bdbd..14b7a033 100644
--- a/installed-tests/js/.eslintrc.yml
+++ b/installed-tests/js/.eslintrc.yml
@@ -2,6 +2,12 @@
 env:
   jasmine: true
 rules:
+  no-restricted-globals:
+    - error
+    - name: fdescribe
+      message: Do not commit fdescribe(). Use describe() instead.
+    - name: fit
+      message: Do not commit fit(). Use it() instead.
   no-restricted-syntax:
     - error
     - selector: CallExpression[callee.name="it"] > ArrowFunctionExpression


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]