[gnome-games/wip/exalm/gtk4: 220/238] ui: Drop unnecessary show() and show_all() calls
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-games/wip/exalm/gtk4: 220/238] ui: Drop unnecessary show() and show_all() calls
- Date: Mon, 19 Aug 2019 20:34:56 +0000 (UTC)
commit b771b95ab2afbc118ed8371191e1299ccceef3e9
Author: Alexander Mikhaylenko <exalm7659 gmail com>
Date: Sun Jul 29 14:15:48 2018 +0500
ui: Drop unnecessary show() and show_all() calls
src/ui/application.vala | 2 +-
src/ui/preferences-page-controllers.vala | 2 --
src/ui/preferences-page-platforms-retro-row.vala | 2 --
src/ui/preferences-page-platforms.vala | 1 -
4 files changed, 1 insertion(+), 6 deletions(-)
---
diff --git a/src/ui/application.vala b/src/ui/application.vala
index 340e3503..1633e4f8 100644
--- a/src/ui/application.vala
+++ b/src/ui/application.vala
@@ -229,7 +229,7 @@ public class Games.Application : Gtk.Application {
window.destroy.connect (() => {
quit_application ();
});
- window.show ();
+ window.present ();
GLib.Timeout.add (500, show_loading_notification);
}
diff --git a/src/ui/preferences-page-controllers.vala b/src/ui/preferences-page-controllers.vala
index e547f2be..8ca33483 100644
--- a/src/ui/preferences-page-controllers.vala
+++ b/src/ui/preferences-page-controllers.vala
@@ -36,7 +36,6 @@ private class Games.PreferencesPageControllers : PreferencesPage {
var box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
box.add (new Gtk.Label (device.get_name ()));
box.margin = 6;
- box.show_all ();
gamepads_list_box.add (box);
}
gamepads_label.visible = i > 0;
@@ -72,7 +71,6 @@ private class Games.PreferencesPageControllers : PreferencesPage {
var box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
box.add (new Gtk.Label (_("Keyboard")));
box.margin = 6;
- box.show_all ();
keyboard_list_box.add (box);
}
diff --git a/src/ui/preferences-page-platforms-retro-row.vala
b/src/ui/preferences-page-platforms-retro-row.vala
index 49ca9c56..520165df 100644
--- a/src/ui/preferences-page-platforms-retro-row.vala
+++ b/src/ui/preferences-page-platforms-retro-row.vala
@@ -75,11 +75,9 @@ private class Games.PreferencesPagePlatformsRetroRow : PreferencesPagePlatformsR
var label = new Gtk.Label (core.get_name ());
label.halign = Gtk.Align.START;
label.margin = 12;
- label.show ();
var row = new Gtk.ListBoxRow ();
row.add (label);
- row.show ();
row_cores[row] = core;
list_box.add (row);
diff --git a/src/ui/preferences-page-platforms.vala b/src/ui/preferences-page-platforms.vala
index 9dc33d1c..03f76e1e 100644
--- a/src/ui/preferences-page-platforms.vala
+++ b/src/ui/preferences-page-platforms.vala
@@ -13,7 +13,6 @@ private class Games.PreferencesPagePlatforms : PreferencesPage {
foreach (var platform in platforms) {
var row = platform.get_row ();
- row.show ();
list_box.add (row);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]