[gnome-shell/benzea/systemd-user-units-with-extension-warning: 2/7] extensionSystem: Redefine canChange property
- From: Benjamin Berg <bberg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/benzea/systemd-user-units-with-extension-warning: 2/7] extensionSystem: Redefine canChange property
- Date: Fri, 30 Aug 2019 14:47:56 +0000 (UTC)
commit 2e6fcc719be7c080ca3be9ba4afde8608f931e74
Author: Benjamin Berg <bberg redhat com>
Date: Thu Aug 1 16:17:20 2019 +0200
extensionSystem: Redefine canChange property
The canChange property was not actually reflecting whether
the enableExtension or disableExtension can change the underlying
setting. Instead the property was showing whether such a change will
have an effect.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/695
js/ui/extensionSystem.js | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index fd7196972d..7885239673 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -363,10 +363,7 @@ var ExtensionManager = class {
? DISABLE_USER_EXTENSIONS_KEY
: ENABLED_EXTENSIONS_KEY;
- extension.canChange =
- !hasError &&
- global.settings.is_writable(changeKey) &&
- (isMode || !modeOnly);
+ extension.canChange = global.settings.is_writable(ENABLED_EXTENSIONS_KEY);
}
_getEnabledExtensions() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]