[gnome-shell/gbsneto/fix-frequent-view-clones] iconGrid: Only animate allocated icons
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/fix-frequent-view-clones] iconGrid: Only animate allocated icons
- Date: Sat, 31 Aug 2019 15:42:02 +0000 (UTC)
commit 04f26d48762d6529ba54cca73358db3ea40ac3c5
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Sat Aug 31 12:32:31 2019 -0300
iconGrid: Only animate allocated icons
Mutter recently added an optimization to only allocate
visible children [1]. That broke ClutterClones, but it
was subsequently fixed [2].
However, that exposed a third problem, this time with
FrequentView: non-allocated icons were being cloned and
animated on the spring animation.
Only animate allocated icons. PaginatedIconGrid does not
require this check since it only animated the visible
page, which is always allocated.
[1] 0eab73dc2e28a52d9c01a2c6e30e32125d0048a7
[2] 08a3cbfc6cfd96f4efd8e25bc2732ad9ea7644f2
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/696
js/ui/iconGrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js
index e0a1e8bd8a..85447972e0 100644
--- a/js/ui/iconGrid.js
+++ b/js/ui/iconGrid.js
@@ -414,7 +414,7 @@ var IconGrid = GObject.registerClass({
* set of items to be animated.
*/
_getChildrenToAnimate() {
- return this._getVisibleChildren();
+ return this._getVisibleChildren().filter(icon => icon.has_allocation());
}
_resetAnimationActors() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]