[gnome-shell] st: Remove broken parsing of @media rules
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] st: Remove broken parsing of @media rules
- Date: Tue, 3 Dec 2019 18:03:27 +0000 (UTC)
commit 73776508b30059d5a71ec3dcfe51e23fc1137dd1
Author: Federico Mena Quintero <federico gnome org>
Date: Mon Dec 2 19:57:08 2019 -0600
st: Remove broken parsing of @media rules
This code didn't even pay attention to the
cur_stmt->kind.media_rule->media_list, and unconditonally considered
each statement in the ->ruleset to be of kind ruleset. That seems
broken.
(The theme doesn't use any @media queries, and they are unsupported
anyway.)
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1979
src/st/st-theme.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
---
diff --git a/src/st/st-theme.c b/src/st/st-theme.c
index 00a2c8fb7e..0d2d2eeace 100644
--- a/src/st/st-theme.c
+++ b/src/st/st-theme.c
@@ -858,16 +858,6 @@ add_matched_properties (StTheme *a_this,
}
break;
- case AT_MEDIA_RULE_STMT:
- if (cur_stmt->kind.media_rule
- && cur_stmt->kind.media_rule->rulesets
- && cur_stmt->kind.media_rule->rulesets->kind.ruleset
- && cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list)
- {
- sel_list = cur_stmt->kind.media_rule->rulesets->kind.ruleset->sel_list;
- }
- break;
-
case AT_IMPORT_RULE_STMT:
{
CRAtImportRule *import_rule = cur_stmt->kind.import_rule;
@@ -908,6 +898,7 @@ add_matched_properties (StTheme *a_this,
}
}
break;
+ case AT_MEDIA_RULE_STMT:
case AT_RULE_STMT:
case AT_PAGE_RULE_STMT:
case AT_CHARSET_RULE_STMT:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]