[tracker/sam/ubuntu-test-fix: 1/2] tests/libtracker-sparql: Rename test to avoid 'NBxxxxx' noise



commit 64fa5bb12e1526b9d83a921ad7e5399dc548c2d3
Author: Sam Thursfield <sam afuera me uk>
Date:   Sun Dec 29 18:02:06 2019 +0000

    tests/libtracker-sparql: Rename test to avoid 'NBxxxxx' noise
    
    The 'NB237150' code refers to a bug tracker which used to only be
    accessible internally at Nokia, and is now inaccessible to anyone.
    Let's give the test a readable name instead.

 tests/libtracker-sparql/tracker-sparql-test.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
---
diff --git a/tests/libtracker-sparql/tracker-sparql-test.c b/tests/libtracker-sparql/tracker-sparql-test.c
index 541031b26..af78929d5 100644
--- a/tests/libtracker-sparql/tracker-sparql-test.c
+++ b/tests/libtracker-sparql/tracker-sparql-test.c
@@ -255,7 +255,7 @@ test_tracker_sparql_connection_locking_async (void)
 }
 
 static void
-test_tracker_sparql_nb237150_cb (GObject      *source_object,
+test_tracker_sparql_get_connection_async_cb (GObject      *source_object,
                                  GAsyncResult *result,
                                  gpointer      user_data)
 {
@@ -283,28 +283,28 @@ test_tracker_sparql_nb237150_cb (GObject      *source_object,
 }
 
 static void
-test_tracker_sparql_nb237150_subprocess (void)
+test_tracker_sparql_get_connection_async_subprocess (void)
 {
        main_loop = g_main_loop_new (NULL, TRUE);
 
        g_print ("\n");
        g_print ("Calling #1 - tracker_sparql_connection_get_async()\n");
-       tracker_sparql_connection_get_async (NULL, test_tracker_sparql_nb237150_cb, GINT_TO_POINTER(1));
+       tracker_sparql_connection_get_async (NULL, test_tracker_sparql_get_connection_async_cb, 
GINT_TO_POINTER(1));
 
        g_print ("Calling #2 - tracker_sparql_connection_get_async()\n");
-       tracker_sparql_connection_get_async (NULL, test_tracker_sparql_nb237150_cb, GINT_TO_POINTER(2));
+       tracker_sparql_connection_get_async (NULL, test_tracker_sparql_get_connection_async_cb, 
GINT_TO_POINTER(2));
 
        g_print ("Calling both finished\n");
        g_main_loop_run (main_loop);
 }
 
 static void
-test_tracker_sparql_nb237150 (void)
+test_tracker_sparql_get_connection_async (void)
 {
-       /* Test NB#237150 - Second tracker_sparql_connection_get_async
-        * never returns
+       /* Regression test for an issue where a second
+        * tracker_sparql_connection_get_async would never return.
         */
-       g_test_trap_subprocess ("/libtracker-sparql/tracker-sparql/nb237150/subprocess",
+       g_test_trap_subprocess ("/libtracker-sparql/tracker-sparql/get_connection_async/subprocess",
                                G_USEC_PER_SEC * 2,
                                G_TEST_SUBPROCESS_INHERIT_STDOUT |
                                G_TEST_SUBPROCESS_INHERIT_STDERR);
@@ -378,10 +378,10 @@ main (gint argc, gchar **argv)
        /* NOTE: this first test must come BEFORE any others because
         * connections are cached by libtracker-sparql.
         */
-       g_test_add_func ("/libtracker-sparql/tracker-sparql/nb237150",
-                        test_tracker_sparql_nb237150);
-       g_test_add_func ("/libtracker-sparql/tracker-sparql/nb237150/subprocess",
-                        test_tracker_sparql_nb237150_subprocess);
+       g_test_add_func ("/libtracker-sparql/tracker-sparql/get_connection_async",
+                        test_tracker_sparql_get_connection_async);
+       g_test_add_func ("/libtracker-sparql/tracker-sparql/get_connection_async/subprocess",
+                        test_tracker_sparql_get_connection_async_subprocess);
        g_test_add_func ("/libtracker-sparql/tracker-sparql/tracker_sparql_escape_string",
                         test_tracker_sparql_escape_string);
        g_test_add_func ("/libtracker-sparql/tracker-sparql/tracker_sparql_escape_uri_vprintf",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]