[gjs: 9/18] lint: Make header include changes suggested by IWYU
- From: Philip Chimento <pchimento src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs: 9/18] lint: Make header include changes suggested by IWYU
- Date: Tue, 31 Dec 2019 23:15:45 +0000 (UTC)
commit 2b30166744c775175e1ab7aa81218d8eb823d665
Author: Philip Chimento <philip chimento gmail com>
Date: Sat Nov 23 23:18:33 2019 -0800
lint: Make header include changes suggested by IWYU
IWYU still gives a number of false positives, but these particular
changes look legit.
gjs/engine.cpp | 1 -
libgjs-private/gjs-util.c | 1 +
modules/system.cpp | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gjs/engine.cpp b/gjs/engine.cpp
index 359bcc77..e03d13db 100644
--- a/gjs/engine.cpp
+++ b/gjs/engine.cpp
@@ -41,7 +41,6 @@
#include "gjs/context-private.h"
#include "gjs/engine.h"
#include "gjs/jsapi-util.h"
-#include "gjs/macros.h"
#include "util/log.h"
/* Implementations of locale-specific operations; these are used
diff --git a/libgjs-private/gjs-util.c b/libgjs-private/gjs-util.c
index a5b44fec..20a732d5 100644
--- a/libgjs-private/gjs-util.c
+++ b/libgjs-private/gjs-util.c
@@ -24,6 +24,7 @@
#include <locale.h> /* for setlocale */
#include <stddef.h> /* for size_t */
+#include <string.h> /* for strcmp */
#include <sys/types.h> /* IWYU pragma: keep */
#include <gio/gio.h>
diff --git a/modules/system.cpp b/modules/system.cpp
index 65494bfa..b0e536db 100644
--- a/modules/system.cpp
+++ b/modules/system.cpp
@@ -41,6 +41,7 @@
#include "gjs/jsapi-util-args.h"
#include "gjs/jsapi-util.h"
#include "modules/system.h"
+#include "util/log.h"
/* Note that this cannot be relied on to test whether two objects are the same!
* SpiderMonkey can move objects around in memory during garbage collection,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]