[gnome-shell/wip/partial-screenlock-bypass: 1/2] panel: Don't allow opening hidden menus via keybindings
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/partial-screenlock-bypass: 1/2] panel: Don't allow opening hidden menus via keybindings
- Date: Tue, 5 Feb 2019 16:09:34 +0000 (UTC)
commit c1a6effea003e4d94b9afa2908a063f22888b809
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Jan 23 23:55:12 2019 +0100
panel: Don't allow opening hidden menus via keybindings
We shouldn't allow toggling menus that aren't supported by the
current session mode, but as indicators are hidden rather than
destroyed on mode switches, it is not enough to check for an
indicator's existence.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/851
js/ui/panel.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/panel.js b/js/ui/panel.js
index 3ce95a16a..8a6cb7722 100644
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -957,8 +957,8 @@ class Panel extends St.Widget {
}
_toggleMenu(indicator) {
- if (!indicator) // menu not supported by current session mode
- return;
+ if (!indicator || !indicator.container.visible)
+ return; // menu not supported by current session mode
let menu = indicator.menu;
if (!indicator.actor.reactive)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]