[mutter] window: Return focusable ability looking at properties only



commit 58d2a674c466b607e18e6c8e129a6cf1646fde7f
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date:   Thu Feb 14 13:47:52 2019 +0100

    window: Return focusable ability looking at properties only
    
    As per commit 43633d6b, we mark an unmanaging window as not focusable, while
    this is true, it might cause not resetting the current focused window when
    unmanaging it causing a crash.
    
    Also this wouldn't allow to check if a window can be focused when unmanaging it,
    so let's revert the previous behavior.
    
    Fixes: https://gitlab.gnome.org/GNOME/mutter/issues/462

 src/core/stack.c  | 3 +++
 src/core/window.c | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/core/stack.c b/src/core/stack.c
index 6dd1ccb9e..7ab590c98 100644
--- a/src/core/stack.c
+++ b/src/core/stack.c
@@ -1224,6 +1224,9 @@ get_default_focus_window (MetaStack     *stack,
       if (window->unmaps_pending > 0)
         continue;
 
+      if (window->unmanaging)
+        continue;
+
       if (!meta_window_is_focusable (window))
         continue;
 
diff --git a/src/core/window.c b/src/core/window.c
index 5f5269b7c..c112c7d59 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -8529,9 +8529,6 @@ meta_window_shortcuts_inhibited (MetaWindow         *window,
 gboolean
 meta_window_is_focusable (MetaWindow *window)
 {
-  if (window->unmanaging)
-    return FALSE;
-
   return META_WINDOW_GET_CLASS (window)->is_focusable (window);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]