[geary/wip/251-appended-mail-closes-composer: 11/11] Fix composer being hidden when autoselect disabled and mail appended

[Michael Gratton <mjog src gnome org>]

commit b7c849f37642228059d03c24fe7c64cb93a8446f
Author: Michael Gratton <mike vee net>
Date:   Thu Feb 21 23:10:12 2019 +1100

    Fix composer being hidden when autoselect disabled and mail appended
    
    When autoselect is disabled, we need to ensure the conversation viewer's
    spinner needs to be hidden at some point, but we don't want to attempt
    to do that if a composer is visible, since there clearly won't be any
    spinner visible.
    
    Fixes #251

 src/client/application/geary-controller.vala | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/src/client/application/geary-controller.vala b/src/client/application/geary-controller.vala
index 499b5d99..dda2a490 100644
--- a/src/client/application/geary-controller.vala
+++ b/src/client/application/geary-controller.vala
@@ -1217,10 +1217,13 @@ public class GearyController : Geary.BaseObject {
                 enable_message_buttons(false);
             } else {
                 // When not doing autoselect, we never get
-                // conversations_selected firing from the convo list, so
-                // we need to stop the loading spinner here
+                // conversations_selected firing from the convo list,
+                // so we need to stop the loading spinner here. Only
+                // do so if there isn't already a selection or a
+                // composer to avoid interrupting those.
                 if (!this.application.config.autoselect &&
-                    list.get_selection().count_selected_rows() == 0) {
+                    list.get_selection().count_selected_rows() == 0 &&
+                    !viewer.is_composer_visible) {
                     viewer.show_none_selected();
                     enable_message_buttons(false);
                 }