[gdm/wip/foreach-fixes: 2/4] xdmcp-display-factory: don't return value from foreach funcs



commit c9e02375dc8f2c636b3698655856c22e9308f60a
Author: Ray Strode <rstrode redhat com>
Date:   Thu Feb 21 15:20:01 2019 -0500

    xdmcp-display-factory: don't return value from foreach funcs
    
    The xdmcp code is returning TRUE from its display store foreach
    functions, which is useless since commit 47d01abe and wrong
    before that.
    
    This commit makes it return void instead.

 daemon/gdm-xdmcp-display-factory.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/daemon/gdm-xdmcp-display-factory.c b/daemon/gdm-xdmcp-display-factory.c
index 270685d0..220ee3af 100644
--- a/daemon/gdm-xdmcp-display-factory.c
+++ b/daemon/gdm-xdmcp-display-factory.c
@@ -666,7 +666,7 @@ typedef struct {
         int         count;
 } CountDisplayData;
 
-static gboolean
+static void
 count_displays_from_host (const char       *id,
                           GdmDisplay       *display,
                           CountDisplayData *data)
@@ -680,8 +680,6 @@ count_displays_from_host (const char       *id,
                         data->count++;
                 }
         }
-
-        return TRUE;
 }
 
 static int
@@ -1807,7 +1805,7 @@ gdm_xdmcp_send_got_managed_forward (GdmXdmcpDisplayFactory *factory,
                     (int)gdm_sockaddr_len (gdm_address_peek_sockaddr_storage (address)));
 }
 
-static gboolean
+static void
 count_sessions (const char             *id,
                 GdmDisplay             *display,
                 GdmXdmcpDisplayFactory *factory)
@@ -1823,8 +1821,6 @@ count_sessions (const char             *id,
                         factory->num_pending_sessions++;
                 }
         }
-
-        return TRUE;
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]