[totem/wip/hadess/update-plugin-names: 4/4] plugins: Don't save builtin plugins to GSettings
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [totem/wip/hadess/update-plugin-names: 4/4] plugins: Don't save builtin plugins to GSettings
- Date: Sat, 23 Feb 2019 16:11:57 +0000 (UTC)
commit 57b787964a55dd13a0c037e5314a175c6a9ef63d
Author: Bastien Nocera <hadess hadess net>
Date: Sat Feb 23 17:09:39 2019 +0100
plugins: Don't save builtin plugins to GSettings
Builtin plugins are not meant to be disabled by users and are thus not
part of user settings. This also stops Totem from writing to GSettings
on startup.
Closes: #145
data/org.gnome.totem.gschema.xml.in | 2 +-
src/plugins/totem-plugins-engine.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/data/org.gnome.totem.gschema.xml.in b/data/org.gnome.totem.gschema.xml.in
index fccb4e45e..8f7937a18 100644
--- a/data/org.gnome.totem.gschema.xml.in
+++ b/data/org.gnome.totem.gschema.xml.in
@@ -77,7 +77,7 @@
<summary>Whether to autoload external chapter files when a movie is loaded</summary>
</key>
<key name="active-plugins" type="as">
-
<default>['skipto','chapters','screenshot','media_player_keys','screensaver','movie-properties','save-file']</default>
+ <default>[]</default>
<summary>Active plugins list</summary>
<description>A list of the names of the plugins which are currently active (loaded
and running).</description>
</key>
diff --git a/src/plugins/totem-plugins-engine.c b/src/plugins/totem-plugins-engine.c
index 62788e661..2d27cf403 100644
--- a/src/plugins/totem-plugins-engine.c
+++ b/src/plugins/totem-plugins-engine.c
@@ -133,7 +133,9 @@ totem_plugins_engine_get_default (TotemObject *totem)
g_signal_connect (engine->priv->activatable_extensions, "extension-removed",
G_CALLBACK (on_activatable_extension_removed), engine);
- g_settings_bind (engine->priv->settings, "active-plugins", engine, "loaded-plugins",
G_SETTINGS_BIND_DEFAULT | G_SETTINGS_BIND_NO_SENSITIVITY);
+ g_settings_bind (engine->priv->settings, "active-plugins",
+ engine, "loaded-external-plugins",
+ G_SETTINGS_BIND_DEFAULT | G_SETTINGS_BIND_NO_SENSITIVITY);
/* Load builtin plugins */
plugin_infos = peas_engine_get_plugin_list (PEAS_ENGINE (engine));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]