[iagno] Improve code.
- From: Arnaud B. <arnaudb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [iagno] Improve code.
- Date: Mon, 25 Feb 2019 21:01:43 +0000 (UTC)
commit 8c4550be558ffef1ca18286001c1f04d9216d08b
Author: Arnaud Bonatti <arnaud bonatti gmail com>
Date: Mon Feb 25 20:12:19 2019 +0100
Improve code.
src/computer-player.vala | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
---
diff --git a/src/computer-player.vala b/src/computer-player.vala
index dc7fa95..0b029fa 100644
--- a/src/computer-player.vala
+++ b/src/computer-player.vala
@@ -100,18 +100,18 @@ private class ComputerPlayer : Object
/* For tests only. */
internal void move ()
{
- uint8 x = 0;
- uint8 y = 0;
+ uint8 x;
+ uint8 y;
- run_search (ref x, ref y);
+ run_search (out x, out y);
complete_move (x, y);
}
internal async void move_async (double delay_seconds = 0.0)
{
Timer timer = new Timer ();
- uint8 x = 0;
- uint8 y = 0;
+ uint8 x = 0; // garbage, should not be needed
+ uint8 y = 0; // idem
while (move_pending)
{
@@ -124,7 +124,7 @@ private class ComputerPlayer : Object
timer.start ();
new Thread<void *> ("AI thread", () => {
move_pending = true;
- run_search (ref x, ref y);
+ run_search (out x, out y);
move_async.callback ();
return null;
});
@@ -172,7 +172,7 @@ private class ComputerPlayer : Object
* * Minimax / Negamax / alpha-beta pruning
\*/
- private void run_search (ref uint8 x, ref uint8 y)
+ private void run_search (out uint8 x, out uint8 y)
requires (game.current_player_can_move)
{
/* For the first/first two moves play randomly so the game is not always the same */
@@ -182,6 +182,9 @@ private class ComputerPlayer : Object
return;
}
+ x = 0; // garbage
+ y = 0; // idem
+
/* Choose a location to place by building the tree of possible moves and
* using the minimax algorithm to pick the best branch with the chosen
* strategy. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]