[geary/wip/account-editor-refinements-v1: 6/7] Don't validate managed	accounts when validating account server details
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [geary/wip/account-editor-refinements-v1: 6/7] Don't validate managed	accounts when validating account server details
- Date: Wed,  9 Jan 2019 02:33:05 +0000 (UTC)
commit db85a3449d26ad645f6fee3d161f465b77f44bbb
Author: Michael Gratton <mike vee net>
Date:   Wed Jan 9 12:26:13 2019 +1100
    Don't validate managed accounts when validating account server details
    
    GOA supports generic IMAP accounts, we shouldn't be attempting to
    validate the server settings for those.
 src/client/accounts/accounts-editor-servers-pane.vala | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/src/client/accounts/accounts-editor-servers-pane.vala 
b/src/client/accounts/accounts-editor-servers-pane.vala
index 49004cc2..38a4b3c0 100644
--- a/src/client/accounts/accounts-editor-servers-pane.vala
+++ b/src/client/accounts/accounts-editor-servers-pane.vala
@@ -238,12 +238,14 @@ internal class Accounts.EditorServersPane :
     private async void save(GLib.Cancellable? cancellable) {
         this.is_operation_running = true;
 
-        // Only need to validate if a generic account
+        // Only need to validate if a generic, local account since
+        // other account types have read-only incoming/outgoing
+        // settings
         bool is_valid = true;
         bool has_changed = false;
-        if (this.account.service_provider == Geary.ServiceProvider.OTHER) {
+        if (this.account.service_provider == Geary.ServiceProvider.OTHER &&
+            !this.editor.accounts.is_goa_account(this.account)) {
             is_valid = yield validate(cancellable);
-
             if (is_valid) {
                 has_changed |= yield update_service(
                     this.account.incoming, this.incoming_mutable, cancellable
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]