[balsa] Fix some scan-build reports
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa] Fix some scan-build reports
- Date: Sat, 6 Jul 2019 16:44:35 +0000 (UTC)
commit fb4324ce05e86f5eeee072684d9eca35f9c7e2c7
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Sat Jul 6 12:43:24 2019 -0400
Fix some scan-build reports
* libbalsa/mailbox.c (libbalsa_mailbox_set_threading_type),
(libbalsa_mailbox_set_subject_gather),
(libbalsa_mailbox_set_sort_type),
(libbalsa_mailbox_set_sort_field), (libbalsa_mailbox_set_show),
(libbalsa_mailbox_set_subscribe), (libbalsa_mailbox_set_exposed),
(libbalsa_mailbox_set_open), (libbalsa_mailbox_set_filter):
remove a dead store;
* libbalsa/mailbox_imap.c
(libbalsa_mailbox_imap_get_selected_handle): initialize readonly
to FALSE.
ChangeLog | 15 +++++++++++++++
libbalsa/mailbox.c | 21 ++++++++++-----------
libbalsa/mailbox_imap.c | 4 +---
3 files changed, 26 insertions(+), 14 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d4b38ea20..3717a722c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2019-07-06 Peter Bloomfield <pbloomfield bellsouth net>
+
+ Fix some scan-build reports
+
+ * libbalsa/mailbox.c (libbalsa_mailbox_set_threading_type),
+ (libbalsa_mailbox_set_subject_gather),
+ (libbalsa_mailbox_set_sort_type),
+ (libbalsa_mailbox_set_sort_field), (libbalsa_mailbox_set_show),
+ (libbalsa_mailbox_set_subscribe), (libbalsa_mailbox_set_exposed),
+ (libbalsa_mailbox_set_open), (libbalsa_mailbox_set_filter):
+ remove a dead store;
+ * libbalsa/mailbox_imap.c
+ (libbalsa_mailbox_imap_get_selected_handle): initialize readonly
+ to FALSE.
+
2019-07-06 Peter Bloomfield <pbloomfield bellsouth net>
mailbox-{remote,imap}: Simplify dispose() methods
diff --git a/libbalsa/mailbox.c b/libbalsa/mailbox.c
index 6454db90d..6d9152bc7 100644
--- a/libbalsa/mailbox.c
+++ b/libbalsa/mailbox.c
@@ -2433,10 +2433,9 @@ libbalsa_mailbox_set_identity_name(LibBalsaMailbox * mailbox,
void
libbalsa_mailbox_set_threading_type(LibBalsaMailbox * mailbox,
- LibBalsaMailboxThreadingType
- threading_type)
+ LibBalsaMailboxThreadingType threading_type)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2452,7 +2451,7 @@ void
libbalsa_mailbox_set_subject_gather(LibBalsaMailbox * mailbox,
gboolean subject_gather)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2468,7 +2467,7 @@ void
libbalsa_mailbox_set_sort_type(LibBalsaMailbox * mailbox,
LibBalsaMailboxSortType sort_type)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2484,7 +2483,7 @@ void
libbalsa_mailbox_set_sort_field(LibBalsaMailbox * mailbox,
LibBalsaMailboxSortFields sort_field)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2500,7 +2499,7 @@ libbalsa_mailbox_set_sort_field(LibBalsaMailbox * mailbox,
gboolean
libbalsa_mailbox_set_show(LibBalsaMailbox * mailbox, LibBalsaMailboxShow show)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_val_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox), FALSE);
view = lbm_get_view(mailbox);
@@ -2520,7 +2519,7 @@ gboolean
libbalsa_mailbox_set_subscribe(LibBalsaMailbox * mailbox,
LibBalsaMailboxSubscribe subscribe)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_val_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox), FALSE);
view = lbm_get_view(mailbox);
@@ -2539,7 +2538,7 @@ libbalsa_mailbox_set_subscribe(LibBalsaMailbox * mailbox,
void
libbalsa_mailbox_set_exposed(LibBalsaMailbox * mailbox, gboolean exposed)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2554,7 +2553,7 @@ libbalsa_mailbox_set_exposed(LibBalsaMailbox * mailbox, gboolean exposed)
void
libbalsa_mailbox_set_open(LibBalsaMailbox * mailbox, gboolean open)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
@@ -2572,7 +2571,7 @@ libbalsa_mailbox_set_open(LibBalsaMailbox * mailbox, gboolean open)
void
libbalsa_mailbox_set_filter(LibBalsaMailbox * mailbox, gint filter)
{
- LibBalsaMailboxView *view = lbm_get_view(mailbox);
+ LibBalsaMailboxView *view;
g_return_if_fail(mailbox == NULL || LIBBALSA_IS_MAILBOX(mailbox));
view = lbm_get_view(mailbox);
diff --git a/libbalsa/mailbox_imap.c b/libbalsa/mailbox_imap.c
index ef62a420f..8f0ee480e 100644
--- a/libbalsa/mailbox_imap.c
+++ b/libbalsa/mailbox_imap.c
@@ -957,9 +957,7 @@ libbalsa_mailbox_imap_get_selected_handle(LibBalsaMailboxImap *mimap,
LibBalsaImapServer *imap_server;
ImapResponse rc;
unsigned uidval;
- gboolean readonly;
-
- g_return_val_if_fail(LIBBALSA_MAILBOX_IMAP(mimap), NULL);
+ gboolean readonly = FALSE;
server = LIBBALSA_MAILBOX_REMOTE_SERVER(mimap);
if (!LIBBALSA_IS_IMAP_SERVER(server))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]