[tracker-miners/wip/jfelder/audio-writeback: 121/127] writeback: Remove the taglib based extractor

[Sam Thursfield <sthursfield src gnome org>]

commit 0bb5da53e78399d9cba2b453ab075c523806973f
Author: Sam Thursfield <sam afuera me uk>
Date:   Mon Jul 8 11:39:14 2019 +0100

    writeback: Remove the taglib based extractor
    
    This hasn't been used in a long time, we can be sure of that since
    writeback didn't work at all in several major releases (see
    https://gitlab.gnome.org/GNOME/tracker-miners/issues/55).
    
    The new GStreamer extract module allows us to remove the taglib
    dependency. It supports more tags than the old module. It declares
    supports for less formats, but some of the formats that the old
    module supported were dubious anyway (does audio/x-midi even have
    a metadata block?)

 meson.build                                      |   2 -
 meson_options.txt                                |   2 -
 src/tracker-writeback/meson.build                |   4 -
 src/tracker-writeback/tracker-writeback-taglib.c | 289 -----------------------
 4 files changed, 297 deletions(-)
---
diff --git a/meson.build b/meson.build
index c65569824..70d085f36 100644
--- a/meson.build
+++ b/meson.build
@@ -93,7 +93,6 @@ libtiff = dependency('libtiff-4', required: get_option('tiff'))
 libxml2 = dependency('libxml-2.0', version: '>= 2.6', required: get_option('xml'))
 libvorbis = dependency('vorbisfile', version: '>= 0.22', required: get_option('vorbis'))
 poppler = dependency('poppler-glib', version: '>= 0.16.0', required: get_option('pdf'))
-taglib = dependency('taglib_c', version: '>= 1.6', required: get_option('taglib'))
 totem_plparser = dependency('totem-plparser', required: get_option('playlist'))
 upower = dependency('upower-glib', version: '>= 0.9.0', required: false)
 zlib = dependency('zlib')
@@ -470,7 +469,6 @@ endif
 if have_tracker_writeback
   summary += [
     '\nWriteback Formats:',
-    '    Audio files using Taglib:               ' + taglib.found().to_string(),
     '    Audio files using GStreamer:            ' + (gstreamer.found() and gstreamer_tag.found() and 
gstreamer_audio.found()).to_string(),
     '    XMP:                                    ' + exempi.found().to_string(),
   ]
diff --git a/meson_options.txt b/meson_options.txt
index 25145eecf..ca00f1fc1 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -57,8 +57,6 @@ option('png', type: 'feature', value: 'auto',
        description: 'Support extracting metadata from PNG images')
 option('raw', type: 'feature', value: 'auto',
        description: 'Support extracting metadata from RAW photos')
-option('taglib', type: 'feature', value: 'auto',
-       description: 'Support writeback for audio files using Taglib')
 option('tiff', type: 'feature', value: 'auto',
        description: 'Support extracting metadata from TIFF images')
 option('vorbis', type: 'feature', value: 'auto',
diff --git a/src/tracker-writeback/meson.build b/src/tracker-writeback/meson.build
index 4c4c4629c..375181d21 100644
--- a/src/tracker-writeback/meson.build
+++ b/src/tracker-writeback/meson.build
@@ -6,10 +6,6 @@
 
 modules = []
 
-if taglib.found()
-  modules += [['writeback-taglib', 'tracker-writeback-taglib.c', [tracker_miner, tracker_sparql, 
tracker_miners_common_dep, taglib]]]
-endif
-
 if gstreamer.found() and gstreamer_tag.found() and gstreamer_audio.found()
   modules += [['writeback-gstreamer', 'tracker-writeback-gstreamer.c', [tracker_miner, tracker_sparql, 
tracker_miners_common_dep, gstreamer, gstreamer_tag]]]
 endif