[seahorse/wip/ricotz/issue216] Build with -DSECRET_WITH_UNSTABLE
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [seahorse/wip/ricotz/issue216] Build with -DSECRET_WITH_UNSTABLE
- Date: Mon, 4 Mar 2019 13:51:18 +0000 (UTC)
commit 436aca721ca4c97b46d606621e62a22733e0b9b0
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Sat Mar 2 20:18:29 2019 +0100
Build with -DSECRET_WITH_UNSTABLE
This is required when using unstable API of libsecret
Fixes https://gitlab.gnome.org/GNOME/seahorse/issues/216
gkr/gkr-backend.vala | 8 +-------
meson.build | 1 +
2 files changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/gkr/gkr-backend.vala b/gkr/gkr-backend.vala
index 03d1b24b..44bf065e 100644
--- a/gkr/gkr-backend.vala
+++ b/gkr/gkr-backend.vala
@@ -17,10 +17,6 @@
* License along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
-// FIXME: this is needed since the libsecret VAPI is broken (string is not marked as unowned).
-// We're also using the sync version for the time being since it becomes a mess otherwise.
-extern unowned string? secret_service_read_alias_dbus_path_sync (Secret.Service service, string alias,
Cancellable? cancellable = null) throws GLib.Error;
-
namespace Seahorse {
namespace Gkr {
@@ -182,9 +178,7 @@ public class Backend: GLib.Object , Gcr.Collection, Seahorse.Backend {
return;
try {
- // FIXME: see the comment at the top of the file about the broken VAPI.
- // Once the bindings are fixed, use the async version again.
- var object_path = secret_service_read_alias_dbus_path_sync(this._service, name);
+ var object_path = this._service.read_alias_dbus_path_sync(name);
if (object_path != null) {
this._aliases[name] = object_path;
notify_property("aliases");
diff --git a/meson.build b/meson.build
index e379257d..11706dac 100644
--- a/meson.build
+++ b/meson.build
@@ -100,6 +100,7 @@ add_project_arguments([
add_project_arguments([
'-DGCR_API_SUBJECT_TO_CHANGE',
'-DGCK_API_SUBJECT_TO_CHANGE',
+ '-DSECRET_WITH_UNSTABLE',
'-include', 'config.h',
],
language: 'c',
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]