[gimp] Issue #3133: Gimp freezes after selecting a filter preset and...

[Jehan <jehanp src gnome org>]

commit 03dc24455ab1616204a9ec8fd20070d4411b0b2c
Author: Jehan <jehan girinstud io>
Date:   Wed Mar 20 14:48:40 2019 +0100

    Issue #3133: Gimp freezes after selecting a filter preset and...
    
    ... clicking a GimpChain.
    Since commit c0c055b4e9, gimp_chain_button_set_active() emits the
    "toggled" signal. There is no need to emit it separately from
    GimpOperationTool when setting presets with
    gimp_operation_tool_set_config().
    
    In particular, since the "toggled" signal was even sent unconditionnally
    here, our code was ending creating several GBinding for the same 2
    adjustments, which was creating an infinite loop.

 app/tools/gimpoperationtool.c | 4 ----
 1 file changed, 4 deletions(-)
---
diff --git a/app/tools/gimpoperationtool.c b/app/tools/gimpoperationtool.c
index bb5b1a6486..c4ca4b47ff 100644
--- a/app/tools/gimpoperationtool.c
+++ b/app/tools/gimpoperationtool.c
@@ -755,8 +755,6 @@ gimp_operation_tool_unlink_chains (GimpOperationTool *op_tool)
       if (active)
         {
           gimp_chain_button_set_active (chain, FALSE);
-
-          g_signal_emit_by_name (chain, "toggled");
         }
 
       chains = chains->next;
@@ -800,8 +798,6 @@ gimp_operation_tool_relink_chains (GimpOperationTool *op_tool)
               g_value_get_double (&double_y))
             {
               gimp_chain_button_set_active (chain, TRUE);
-
-              g_signal_emit_by_name (chain, "toggled");
             }
 
           g_value_unset (&double_x);