[gnome-music/wip/jfelder/mpris-cleanup: 10/12] mpris: Fix some PEP-8 issues
- From: Jean Felder <jfelder src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music/wip/jfelder/mpris-cleanup: 10/12] mpris: Fix some PEP-8 issues
- Date: Thu, 21 Mar 2019 21:49:28 +0000 (UTC)
commit 823ace3c9e0f7bc17e1feaf91d4f614fb16e537c
Author: Jean Felder <jfelder src gnome org>
Date: Mon Mar 18 15:09:56 2019 +0100
mpris: Fix some PEP-8 issues
Mostly some lines being too long.
gnomemusic/mpris.py | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
---
diff --git a/gnomemusic/mpris.py b/gnomemusic/mpris.py
index ca9b91ee..05548c79 100644
--- a/gnomemusic/mpris.py
+++ b/gnomemusic/mpris.py
@@ -722,19 +722,23 @@ class MPRIS(DBusInterface):
elif interface_name == MPRIS.MEDIA_PLAYER2_PLAYER_IFACE:
position_msecond = int(self._player.get_position() * 1e6)
metadata = self._get_metadata(self._player.props.current_song)
+ playback_status = self._get_playback_status()
+ is_shuffle = (self._player.props.repeat_mode == RepeatMode.SHUFFLE)
+ can_play = (self._player.props.current_song is not None)
+ has_previous = (self._player.props.has_previous)
return {
- 'PlaybackStatus': GLib.Variant('s', self._get_playback_status()),
+ 'PlaybackStatus': GLib.Variant('s', playback_status),
'LoopStatus': GLib.Variant('s', self._get_loop_status()),
'Rate': GLib.Variant('d', 1.0),
- 'Shuffle': GLib.Variant('b', self._player.props.repeat_mode == RepeatMode.SHUFFLE),
+ 'Shuffle': GLib.Variant('b', is_shuffle),
'Metadata': GLib.Variant('a{sv}', metadata),
'Position': GLib.Variant('x', position_msecond),
'MinimumRate': GLib.Variant('d', 1.0),
'MaximumRate': GLib.Variant('d', 1.0),
'CanGoNext': GLib.Variant('b', self._player.props.has_next),
- 'CanGoPrevious': GLib.Variant('b', self._player.props.has_previous),
- 'CanPlay': GLib.Variant('b', self._player.props.current_song is not None),
- 'CanPause': GLib.Variant('b', self._player.props.current_song is not None),
+ 'CanGoPrevious': GLib.Variant('b', has_previous),
+ 'CanPlay': GLib.Variant('b', can_play),
+ 'CanPause': GLib.Variant('b', can_play),
'CanSeek': GLib.Variant('b', True),
'CanControl': GLib.Variant('b', True),
}
@@ -744,10 +748,11 @@ class MPRIS(DBusInterface):
'CanEditTracks': GLib.Variant('b', False)
}
elif interface_name == MPRIS.MEDIA_PLAYER2_PLAYLISTS_IFACE:
+ active_playlist = self._get_active_playlist()
return {
'PlaylistCount': GLib.Variant('u', len(self._playlists)),
'Orderings': GLib.Variant('as', ['Alphabetical']),
- 'ActivePlaylist': GLib.Variant('(b(oss))', self._get_active_playlist()),
+ 'ActivePlaylist': GLib.Variant('(b(oss))', active_playlist),
}
elif interface_name == 'org.freedesktop.DBus.Properties':
return {}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]