[geary: 3/4] conversation-web-view: de-globalize a variable



commit 585c7ba5bceb3252d77a78a4148b0aef8e89a340
Author: Konstantin Kharlamov <Hi-Angel yandex ru>
Date:   Fri Mar 22 02:00:22 2019 +0300

    conversation-web-view: de-globalize a variable
    
    Implicitly declared variables in JS are global by default.
    
    Fixes LGTM warning: "Variable header is used like a local variable, but
    is missing a declaration."
    
    Signed-off-by: Konstantin Kharlamov <Hi-Angel yandex ru>

 ui/conversation-web-view.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/ui/conversation-web-view.js b/ui/conversation-web-view.js
index f3bac6a7..a76e3c36 100644
--- a/ui/conversation-web-view.js
+++ b/ui/conversation-web-view.js
@@ -43,7 +43,7 @@ ConversationPageState.prototype = {
 
         headerTable = document.createElement('table');
         headerTable.id = 'geary-message-headers';
-        for (header in headers) {
+        for (var header in headers) {
             let row = headerTable.appendChild(document.createElement('tr'));
             let name = row.appendChild(document.createElement('th'));
             let value = row.appendChild(document.createElement('td'));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]