[epiphany/mcatanzaro/reader-mode-crash: 12/12] web-view: Fix crash when changing reader mode preferences
- From: Jan-Michael Brummer <jbrummer src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/reader-mode-crash: 12/12] web-view: Fix crash when changing reader mode preferences
- Date: Wed, 27 Mar 2019 06:10:23 +0000 (UTC)
commit 63fcfdd651b2c5ebb451598ba362fd5e3b4ced6e
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Tue Mar 26 17:37:05 2019 -0500
web-view: Fix crash when changing reader mode preferences
We shouldn't run the signal handler after the web view is destroyed.
Fixes #706
embed/ephy-web-view.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index 3c634bce1..a7727c59b 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -2819,13 +2819,13 @@ ephy_web_view_init (EphyWebView *web_view)
web_view->history_service = ephy_embed_shell_get_global_history_service (ephy_embed_shell_get_default ());
web_view->history_service_cancellable = g_cancellable_new ();
- g_signal_connect (EPHY_SETTINGS_READER, "changed::" EPHY_PREFS_READER_FONT_STYLE,
- G_CALLBACK (reader_setting_changed_cb),
- web_view);
+ g_signal_connect_object (EPHY_SETTINGS_READER, "changed::" EPHY_PREFS_READER_FONT_STYLE,
+ G_CALLBACK (reader_setting_changed_cb),
+ web_view, 0);
- g_signal_connect (EPHY_SETTINGS_READER, "changed::" EPHY_PREFS_READER_COLOR_SCHEME,
- G_CALLBACK (reader_setting_changed_cb),
- web_view);
+ g_signal_connect_object (EPHY_SETTINGS_READER, "changed::" EPHY_PREFS_READER_COLOR_SCHEME,
+ G_CALLBACK (reader_setting_changed_cb),
+ web_view, 0);
g_signal_connect (web_view, "decide-policy",
G_CALLBACK (decide_policy_cb),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]