[gnome-shell] dialog: Really set ellipsize mode in subtitle and body
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] dialog: Really set ellipsize mode in subtitle and body
- Date: Fri, 3 May 2019 20:59:28 +0000 (UTC)
commit 3121c9aa29406ad85e949b697e90092f1fa6fc2e
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date: Fri May 3 15:27:13 2019 -0500
dialog: Really set ellipsize mode in subtitle and body
Dialog's subtitle or body could not be properly wrapped, while it's ellipsized
when the text's width doesn't exceed the container size.
Clutter text has an `ellipsize` property, however in dialog's subtitle and body
we have been setting the `ellipsize-mode` property to Pango.EllipsizeMode.NONE
that is not present in the underlying GObject.
Not being an error in javascript, gjs didn't warn us about this, while at the
same time the St.Label's default Pango.EllipsizeMode.END was used.
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/922
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/531
js/ui/dialog.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index 809acffbb..41a076353 100644
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -175,7 +175,7 @@ var MessageDialogContent = GObject.registerClass({
this[`_${prop}`].add_style_class_name(`message-dialog-${prop}`);
});
- let textProps = { ellipsize_mode: Pango.EllipsizeMode.NONE,
+ let textProps = { ellipsize: Pango.EllipsizeMode.NONE,
line_wrap: true };
Object.assign(this._subtitle.clutter_text, textProps);
Object.assign(this._body.clutter_text, textProps);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]