[gnome-builder] git: sort tags and branches



commit 8e8470db88694b1ca5e36103c6b7d648b83aa11d
Author: Christian Hergert <chergert redhat com>
Date:   Sun May 5 16:40:09 2019 -0700

    git: sort tags and branches

 src/plugins/git/daemon/ipc-git-repository-impl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/git/daemon/ipc-git-repository-impl.c 
b/src/plugins/git/daemon/ipc-git-repository-impl.c
index 9d247220e..2e7d24e7d 100644
--- a/src/plugins/git/daemon/ipc-git-repository-impl.c
+++ b/src/plugins/git/daemon/ipc-git-repository-impl.c
@@ -244,7 +244,7 @@ ipc_git_repository_impl_handle_path_is_ignored (IpcGitRepository      *repositor
 }
 
 static gint
-compare_tags (gconstpointer a,
+compare_refs (gconstpointer a,
               gconstpointer b)
 {
   return g_utf8_collate (*(const gchar **)a, *(const gchar **)b);
@@ -293,14 +293,13 @@ ipc_git_repository_impl_handle_list_refs_by_kind (IpcGitRepository      *reposit
       if (!(names = ggit_repository_list_tags (self->repository, &error)))
         return complete_wrapped_error (invocation, error);
 
-      qsort (names, g_strv_length (names), sizeof (gchar *), compare_tags);
-
       for (guint i = 0; names[i] != NULL; i++)
         g_ptr_array_add (ret, g_steal_pointer (&names[i]));
     }
   else
     g_assert_not_reached ();
 
+  qsort (ret->pdata, ret->len, sizeof (gchar *), compare_refs);
   g_ptr_array_add (ret, NULL);
 
   ipc_git_repository_complete_list_refs_by_kind (repository,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]