[gnome-maps/wip/mlundblad/search-as-you-type: 9/9] WIP: placeEntry: Auto-complete searches
- From: Marcus Lundblad <mlundblad src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-maps/wip/mlundblad/search-as-you-type: 9/9] WIP: placeEntry: Auto-complete searches
- Date: Tue, 14 May 2019 20:17:49 +0000 (UTC)
commit e3ed5f6a0fa364f803864363d7c1623f6529c87d
Author: Marcus Lundblad <ml update uu se>
Date: Sun May 5 21:38:14 2019 +0200
WIP: placeEntry: Auto-complete searches
src/placeEntry.js | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
---
diff --git a/src/placeEntry.js b/src/placeEntry.js
index 8fc86f5..707754a 100644
--- a/src/placeEntry.js
+++ b/src/placeEntry.js
@@ -34,6 +34,9 @@ const PlaceStore = imports.placeStore;
const PlacePopover = imports.placePopover;
const Utils = imports.utils;
+// minimum number of characters to start completion, TODO: how to handle ideographs?
+const MIN_CHARS_COMPLETION = 3;
+
var PlaceEntry = GObject.registerClass({
Properties: {
'place': GObject.ParamSpec.object('place',
@@ -103,18 +106,28 @@ var PlaceEntry = GObject.registerClass({
if (this._cancellable)
this._cancellable.cancel();
- this._refreshFilter();
+ //this._refreshFilter();
if (this.text.length === 0) {
this._popover.hide();
this.place = null;
+ this._previousSearch = null;
+ return;
+ } else if (this.text.length >= MIN_CHARS_COMPLETION) {
+ // if no previous search has been performed, show spinner
+ if (!this._previousSearch ||
+ this._previousSearch.length < MIN_CHARS_COMPLETION)
+ this._popover.showSpinner();
+ this._doSearch();
return;
}
+ /*
if (this._filter.iter_n_children(null) > 0)
this._popover.showCompletion();
else
this._popover.hide();
+ */
});
if (parseOnFocusOut) {
@@ -207,7 +220,10 @@ var PlaceEntry = GObject.registerClass({
let bbox = this._mapView.view.get_bounding_box();
this._popover.showSpinner();
+ this._doSearch();
+ }
+ _doSearch() {
this._cancellable = new Gio.Cancellable();
Application.photonGeocode.search(this.text,
this._mapView.view.latitude,
@@ -222,6 +238,7 @@ var PlaceEntry = GObject.registerClass({
}
this._popover.updateResult(places, this.text);
this._popover.showResult();
+ this._previousSearch = this.text;
});
}
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]