[librsvg: 1/8] Rename NodeDefs to NodeNonRendering



commit 32fa6e437eede51922277a32a874af9f2cd3e907
Author: Federico Mena Quintero <federico gnome org>
Date:   Thu May 16 17:06:02 2019 -0500

    Rename NodeDefs to NodeNonRendering
    
    This will be a generic catch-all node for <defs> itself, and for
    nodes which don't render themselves and don't have any special
    handling.

 rsvg_internals/src/create_node.rs |  4 ++--
 rsvg_internals/src/structure.rs   | 16 ++++++++++------
 2 files changed, 12 insertions(+), 8 deletions(-)
---
diff --git a/rsvg_internals/src/create_node.rs b/rsvg_internals/src/create_node.rs
index d2f9461b..d9a2694f 100644
--- a/rsvg_internals/src/create_node.rs
+++ b/rsvg_internals/src/create_node.rs
@@ -29,7 +29,7 @@ use crate::pattern::NodePattern;
 use crate::property_bag::PropertyBag;
 use crate::shapes::{NodeCircle, NodeEllipse, NodeLine, NodePath, NodePoly, NodeRect};
 use crate::stop::NodeStop;
-use crate::structure::{NodeDefs, NodeGroup, NodeSvg, NodeSwitch, NodeSymbol, NodeUse};
+use crate::structure::{NodeNonRendering, NodeGroup, NodeSvg, NodeSwitch, NodeSymbol, NodeUse};
 use crate::style::NodeStyle;
 use crate::text::{NodeTRef, NodeTSpan, NodeText};
 
@@ -83,7 +83,7 @@ node_create_fn!(
     FilterPrimitiveConvolveMatrix,
     ConvolveMatrix::new
 );
-node_create_fn!(create_defs, Defs, NodeDefs::new);
+node_create_fn!(create_defs, Defs, NodeNonRendering::new);
 node_create_fn!(
     create_diffuse_lighting,
     FilterPrimitiveDiffuseLighting,
diff --git a/rsvg_internals/src/structure.rs b/rsvg_internals/src/structure.rs
index fd849872..8bc3809b 100644
--- a/rsvg_internals/src/structure.rs
+++ b/rsvg_internals/src/structure.rs
@@ -47,15 +47,19 @@ impl NodeTrait for NodeGroup {
     }
 }
 
-pub struct NodeDefs();
-
-impl NodeDefs {
-    pub fn new() -> NodeDefs {
-        NodeDefs()
+/// A no-op node that does not render anything
+///
+/// Sometimes we just need a node that can contain children, but doesn't
+/// render itself or its children.  This is just that kind of node.
+pub struct NodeNonRendering;
+
+impl NodeNonRendering{
+    pub fn new() -> NodeNonRendering {
+        NodeNonRendering
     }
 }
 
-impl NodeTrait for NodeDefs {
+impl NodeTrait for NodeNonRendering {
     fn set_atts(&self, _: &RsvgNode, _: &PropertyBag<'_>) -> NodeResult {
         Ok(())
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]