[gnome-builder] build: add missing exit macros
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] build: add missing exit macros
- Date: Wed, 22 May 2019 19:12:08 +0000 (UTC)
commit dbff666e2d68d98574267bd0e463652f158a4cff
Author: Christian Hergert <chergert redhat com>
Date: Wed May 22 12:11:42 2019 -0700
build: add missing exit macros
src/libide/code/ide-diagnostics-manager.c | 2 ++
src/libide/code/ide-unsaved-files.c | 8 +++++---
src/libide/foundry/ide-build-manager.c | 2 ++
src/libide/foundry/ide-device-manager.c | 4 ++--
src/libide/lsp/ide-lsp-hover-provider.c | 2 ++
src/libide/sourceview/ide-source-view.c | 4 ++--
src/plugins/editor/gbp-editor-session-addin.c | 2 ++
src/plugins/recent/gbp-recent-workbench-addin.c | 4 ++--
8 files changed, 19 insertions(+), 9 deletions(-)
---
diff --git a/src/libide/code/ide-diagnostics-manager.c b/src/libide/code/ide-diagnostics-manager.c
index c77356dba..63752e984 100644
--- a/src/libide/code/ide-diagnostics-manager.c
+++ b/src/libide/code/ide-diagnostics-manager.c
@@ -453,6 +453,8 @@ ide_diagnostics_group_diagnose_foreach (IdeExtensionSetAdapter *adapter,
NULL,
ide_diagnostics_group_diagnose_cb,
g_object_ref (self));
+
+ IDE_EXIT;
}
static void
diff --git a/src/libide/code/ide-unsaved-files.c b/src/libide/code/ide-unsaved-files.c
index 19b4ae9a9..84cde3e9f 100644
--- a/src/libide/code/ide-unsaved-files.c
+++ b/src/libide/code/ide-unsaved-files.c
@@ -366,13 +366,13 @@ ide_unsaved_files_restore_worker (IdeTask *task,
if (!g_file_test (manifest_path, G_FILE_TEST_IS_REGULAR))
{
ide_task_return_boolean (task, TRUE);
- return;
+ IDE_EXIT;
}
if (!g_file_get_contents (manifest_path, &manifest_contents, &len, &read_error))
{
ide_task_return_error (task, g_steal_pointer (&read_error));
- return;
+ IDE_EXIT;
}
if (len > G_MAXSSIZE)
@@ -381,7 +381,7 @@ ide_unsaved_files_restore_worker (IdeTask *task,
G_IO_ERROR,
G_IO_ERROR_NO_SPACE,
"File is too large to load");
- return;
+ IDE_EXIT;
}
ide_line_reader_init (&reader, manifest_contents, len);
@@ -427,6 +427,8 @@ ide_unsaved_files_restore_worker (IdeTask *task,
}
ide_task_return_boolean (task, TRUE);
+
+ IDE_EXIT;
}
void
diff --git a/src/libide/foundry/ide-build-manager.c b/src/libide/foundry/ide-build-manager.c
index 5a1d5510b..a1ca3b05a 100644
--- a/src/libide/foundry/ide-build-manager.c
+++ b/src/libide/foundry/ide-build-manager.c
@@ -1611,6 +1611,8 @@ ide_build_manager_clean_cb (GObject *object,
ide_task_return_error (task, g_steal_pointer (&error));
else
ide_task_return_boolean (task, TRUE);
+
+ IDE_EXIT;
}
/**
diff --git a/src/libide/foundry/ide-device-manager.c b/src/libide/foundry/ide-device-manager.c
index 60b3bc528..5253270d2 100644
--- a/src/libide/foundry/ide-device-manager.c
+++ b/src/libide/foundry/ide-device-manager.c
@@ -635,11 +635,11 @@ void
ide_device_manager_set_device (IdeDeviceManager *self,
IdeDevice *device)
{
+ IDE_ENTRY;
+
g_return_if_fail (IDE_IS_DEVICE_MANAGER (self));
g_return_if_fail (!device || IDE_IS_DEVICE (device));
- IDE_ENTRY;
-
if (g_set_object (&self->device, device))
{
const gchar *device_id = NULL;
diff --git a/src/libide/lsp/ide-lsp-hover-provider.c b/src/libide/lsp/ide-lsp-hover-provider.c
index 1e38087f7..1760363e2 100644
--- a/src/libide/lsp/ide-lsp-hover-provider.c
+++ b/src/libide/lsp/ide-lsp-hover-provider.c
@@ -426,6 +426,8 @@ ide_lsp_hover_provider_real_load (IdeHoverProvider *provider,
if (IDE_LSP_HOVER_PROVIDER_GET_CLASS (self)->prepare)
IDE_LSP_HOVER_PROVIDER_GET_CLASS (self)->prepare (self);
+
+ IDE_EXIT;
}
static void
diff --git a/src/libide/sourceview/ide-source-view.c b/src/libide/sourceview/ide-source-view.c
index 2d29818ee..011aa7644 100644
--- a/src/libide/sourceview/ide-source-view.c
+++ b/src/libide/sourceview/ide-source-view.c
@@ -7269,7 +7269,7 @@ ide_source_view_move_mark_onscreen (IdeSourceView *self,
gtk_text_view_get_iter_location (text_view, &iter, &iter_rect);
if (_GDK_RECTANGLE_CONTAINS (&visible_rect, &iter_rect))
- return FALSE;
+ IDE_RETURN (FALSE);
if (_GDK_RECTANGLE_Y2 (&iter_rect) > _GDK_RECTANGLE_Y2 (&visible_rect))
gtk_text_view_get_iter_at_location (text_view, &iter,
@@ -7282,7 +7282,7 @@ ide_source_view_move_mark_onscreen (IdeSourceView *self,
gtk_text_buffer_move_mark (buffer, mark, &iter);
- return TRUE;
+ IDE_RETURN (TRUE);
}
static gboolean
diff --git a/src/plugins/editor/gbp-editor-session-addin.c b/src/plugins/editor/gbp-editor-session-addin.c
index 234d0a42d..3dace00cb 100644
--- a/src/plugins/editor/gbp-editor-session-addin.c
+++ b/src/plugins/editor/gbp-editor-session-addin.c
@@ -387,6 +387,8 @@ restore_file (GObject *source,
ide_task_return_boolean (task, TRUE);
}
}
+
+ IDE_EXIT;
}
static void
diff --git a/src/plugins/recent/gbp-recent-workbench-addin.c b/src/plugins/recent/gbp-recent-workbench-addin.c
index 60833eb0b..f97327c1a 100644
--- a/src/plugins/recent/gbp-recent-workbench-addin.c
+++ b/src/plugins/recent/gbp-recent-workbench-addin.c
@@ -98,12 +98,12 @@ gbp_recent_workbench_addin_add_recent (GbpRecentWorkbenchAddin *self,
GFile *file;
GFile *directory;
+ IDE_ENTRY;
+
g_assert (GBP_IS_RECENT_WORKBENCH_ADDIN (self));
g_assert (IDE_IS_WORKBENCH (self->workbench));
g_assert (IDE_IS_PROJECT_INFO (project_info));
- IDE_ENTRY;
-
if (!(file = _ide_project_info_get_real_file (project_info)) ||
directory_is_ignored (file))
IDE_EXIT;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]