[gnome-music/wip/jfelder/mpris-small-cleanups: 2/3] mpris: Use song favourite status to describe userRating



commit 2cfe928702648883c85cb74e6ab31c3dfba55f0c
Author: Jean Felder <jfelder src gnome org>
Date:   Tue Sep 4 18:32:35 2018 +0200

    mpris: Use song favourite status to describe userRating
    
    Music does not handle user ratings but the favourite status can be
    used instead.
    
    Set userRating to 1.0 is song is favourite, 0.0 otherwise.

 gnomemusic/mpris.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/gnomemusic/mpris.py b/gnomemusic/mpris.py
index bc17689c..cfa1b457 100644
--- a/gnomemusic/mpris.py
+++ b/gnomemusic/mpris.py
@@ -295,12 +295,8 @@ class MediaPlayer2Service(Server):
         except:
             pass
 
-        try:
-            userRating = media.get_rating()
-            assert userRating is not None
-            metadata['xesam:userRating'] = GLib.Variant('d', userRating)
-        except:
-            pass
+        user_rating = 1.0 if media.get_favourite() else 0.0
+        metadata['xesam:userRating'] = GLib.Variant('d', user_rating)
 
         try:
             title = utils.get_media_title(media)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]