[gnome-shell/gbsneto/two-popups-no-biscuit] allView: Ensure event blocker is reactive before popup is open
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/two-popups-no-biscuit] allView: Ensure event blocker is reactive before popup is open
- Date: Mon, 11 Nov 2019 16:55:45 +0000 (UTC)
commit 1a9e3edc308b7cdc23196fcde4ce8d67cd031ee7
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Mon Nov 11 13:10:53 2019 -0300
allView: Ensure event blocker is reactive before popup is open
The event blocker in AllView is responsible for stealing click events
from the icon grid and closing the folder popup. The event blocker is
kept unreactive when no folder popup is visible, and it's made reactive
as a response to the 'open-state-changed' signal.
Using this signal, though, is problematic. When opening an app folder,
the icon grid first opens space for the folder to fit in; during this
period, it's possible to click on another folder icon, and break the
icon grid state.
Make sure the event blocker is reactive immediately after clicking on
a folder icon.
Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1470
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/816
js/ui/appDisplay.js | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index f9706aa2eb..51d108b0c2 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -600,6 +600,7 @@ var AllView = GObject.registerClass({
openSpaceForPopup(item, side, nRows) {
this._updateIconOpacities(true);
this._displayingPopup = true;
+ this._eventBlocker.reactive = true;
this._grid.openExtraSpace(item, side, nRows);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]