[gedit-plugins] build: do not set get_option('prefix') to a variable
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gedit-plugins] build: do not set get_option('prefix') to a variable
- Date: Mon, 11 Nov 2019 17:18:31 +0000 (UTC)
commit d947d8093a97741a293bac2e78ba823e0014bff4
Author: Sébastien Wilmet <swilmet gnome org>
Date: Mon Nov 11 17:56:32 2019 +0100
build: do not set get_option('prefix') to a variable
We seeing that variable, we don't know whether it's a global variable or
not. No need to use variables for everything, get_option('prefix') is
short enough and everybody understands it, while it's harder to remember
to use the 'prefix' variable, or when using that variable we need to
look where it is assigned to know what it is.
meson.build | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/meson.build b/meson.build
index 5bf6973..d15b277 100644
--- a/meson.build
+++ b/meson.build
@@ -14,13 +14,11 @@ rootdir = include_directories('.')
srcdir = meson.current_source_dir()
-prefix = get_option('prefix')
-
-bindir = join_paths(prefix, get_option('bindir'))
-includedir = join_paths(prefix, get_option('includedir'))
-libdir = join_paths(prefix, get_option('libdir'))
-libexecdir = join_paths(prefix, get_option('libexecdir'))
-datadir = join_paths(prefix, get_option('datadir'))
+bindir = join_paths(get_option('prefix'), get_option('bindir'))
+includedir = join_paths(get_option('prefix'), get_option('includedir'))
+libdir = join_paths(get_option('prefix'), get_option('libdir'))
+libexecdir = join_paths(get_option('prefix'), get_option('libexecdir'))
+datadir = join_paths(get_option('prefix'), get_option('datadir'))
pkglibdir = join_paths(libdir, 'gedit')
pkgdatadir = join_paths(datadir, 'gedit')
@@ -120,7 +118,7 @@ endforeach
summary += [
'',
'Directories:',
- ' prefix: @0@'.format(prefix),
+ ' prefix: @0@'.format(get_option('prefix')),
' libdir: @0@'.format(libdir),
' datadir: @0@'.format(datadir),
'',
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]