[gnome-shell/wip/carlosg/xwayland-startup-side-channel: 2/2] windowManager: Implement MetaDisplay::init-xserver hook
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/xwayland-startup-side-channel: 2/2] windowManager: Implement MetaDisplay::init-xserver hook
- Date: Fri, 15 Nov 2019 15:33:39 +0000 (UTC)
commit b5e6b9b82ce85b2ea3cd9f8556b3f58628e2f7ce
Author: Carlos Garnacho <carlosg gnome org>
Date: Thu Nov 14 23:56:42 2019 +0100
windowManager: Implement MetaDisplay::init-xserver hook
We do spawn gsd-xsettings, and watch its name before notifying on the
given task, so the mutter bits can proceed with X11 startup.
One notable change is that we only start gsd-xsettings, instead of the
generic gnome-session-x11-services target. We do so as we have to wait
on a dbus name to appear in order to deem the initialization done, and
making it all depend on gsd-xsettings seems tidier.
js/ui/windowManager.js | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js
index 6ba3c965b7..a14bf69d58 100644
--- a/js/ui/windowManager.js
+++ b/js/ui/windowManager.js
@@ -1043,8 +1043,27 @@ var WindowManager = class {
}
});
- global.display.connect('x11-display-opened', () => {
+ global.display.connect('init-xserver', (_display, task) => {
Shell.util_start_systemd_unit('gnome-session-x11-services.target', 'fail');
+ let timeoutId = -1;
+
+ /* When gsd-xsettings daemon is started, we are good to resume */
+ let watchId = Gio.DBus.session.watch_name('org.gnome.SettingsDaemon.XSettings',
+ Gio.BusNameWatcherFlags.NONE,
+ ()=> {
+ task.return_boolean(true);
+ Gio.DBus.session.unwatch_name(watchId);
+ if (timeoutId > 0)
+ GLib.source_remove(timeoutId);
+ },
+ null);
+ /* Anyway, leave this watchdog timeout so don't block indefinitely here */
+ timeoutId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 5, ()=> {
+ Gio.DBus.session.unwatch_name(watchId);
+ task.return_boolean(false);
+ return GLib.SOURCE_REMOVE;
+ });
+ return true;
});
global.display.connect('x11-display-closing', () => {
Shell.util_stop_systemd_unit('gnome-session-x11-services.target', 'fail');
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]