[gnome-shell/gbsneto/dont-create-so-many-icons-pretty-please: 1/3] baseAppView: Destroy icon when removing
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/dont-create-so-many-icons-pretty-please: 1/3] baseAppView: Destroy icon when removing
- Date: Thu, 21 Nov 2019 22:03:43 +0000 (UTC)
commit 4df29c60b3563edea6d7f37235a7cee9715ec5b5
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Thu Nov 21 18:21:44 2019 -0300
baseAppView: Destroy icon when removing
We cannot rely on the garbage collector to do that in a timely
manner, so destroy it explicitly.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841
js/ui/appDisplay.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a49ebe09a8..5b9d4d87fa 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -186,10 +186,11 @@ var BaseAppView = GObject.registerClass({
// Remove old app icons
removedApps.forEach(icon => {
let iconIndex = this._allItems.indexOf(icon);
+ let id = icon.id;
this._allItems.splice(iconIndex, 1);
- this._grid.removeItem(icon);
- delete this._items[icon.id];
+ icon.destroy();
+ delete this._items[id];
});
// Add new app icons
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]