[gnome-shell/gbsneto/dont-create-so-many-icons-pretty-please: 4/6] baseAppView: Destroy icon when removing

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit bfc7c1cd65eee4872aeff837a77f7c6e33aae0ef
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Nov 21 18:21:44 2019 -0300

    baseAppView: Destroy icon when removing
    
    We cannot rely on the garbage collector to do that in a timely
    manner, so destroy it explicitly.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841

 js/ui/appDisplay.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a49ebe09a8..5b9d4d87fa 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -186,10 +186,11 @@ var BaseAppView = GObject.registerClass({
         // Remove old app icons
         removedApps.forEach(icon => {
             let iconIndex = this._allItems.indexOf(icon);
+            let id = icon.id;
 
             this._allItems.splice(iconIndex, 1);
-            this._grid.removeItem(icon);
-            delete this._items[icon.id];
+            icon.destroy();
+            delete this._items[id];
         });
 
         // Add new app icons