[gnome-shell/benzea/systemd-clean-shutdown-with-extension-disabling] data: Enable clean session shutdown after gnome-shell failure
- From: Benjamin Berg <bberg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/benzea/systemd-clean-shutdown-with-extension-disabling] data: Enable clean session shutdown after gnome-shell failure
- Date: Mon, 25 Nov 2019 14:27:19 +0000 (UTC)
commit 9209a37317a097c847b837260b53f426fc1f369b
Author: Benjamin Berg <bberg redhat com>
Date: Mon Nov 25 15:15:01 2019 +0100
data: Enable clean session shutdown after gnome-shell failure
If the GNOME shell crashes, we run a service that may disable
extensions. This is important so that users will not be locked out of
their own session in case an extension is causing crashes.
As this is a very agressive action, we only do so if the session fails
in the first two minutes. The logic to do so was broken though, and
would result in an unclean session shutdown.
Fix this by using the newly introduced file %t/gnome-session-stable and
using a ConditionPathExists. This avoids any depenencies and therefore
can cleanly run in parallel to a normal session shutdown.
Note that it is not a regression to do this even if the gnome-session
part is not yet installed on the system. The result will be to always
disable the extensions rather than just in the first two minutes.
However, due to a bug in the old logic, this was happening anyway.
See
https://gitlab.gnome.org/GNOME/gnome-session/issues/43
https://gitlab.gnome.org/GNOME/gnome-session/merge_requests/31
for a log of the bug happening and the gnome-session part to fix this.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/858
data/gnome-shell-disable-extensions.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/data/gnome-shell-disable-extensions.service b/data/gnome-shell-disable-extensions.service
index d55d7ed879..3aa0e0103a 100644
--- a/data/gnome-shell-disable-extensions.service
+++ b/data/gnome-shell-disable-extensions.service
@@ -5,7 +5,7 @@ DefaultDependencies=no
# Only disable extensions for a short period of time after login.
# This means we err on the side of failing the first login after a broken
# extension was installed.
-Requisite=gnome-session-stable.timer
+Requisite=gnome-session-stable.target
[Service]
Type=simple
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]