[gnome-shell/T27795: 2/138] dnd: Don't mix callback argument and object field usage



commit d30af0f85c14d9deb065580f1f77e92cf32b8e29
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Nov 27 12:21:57 2018 -0200

    dnd: Don't mix callback argument and object field usage
    
    This will be important for the next commit, since _dragComplete()
    changes the value of this._dragActor and we need to keep a valid
    reference to it.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/744

 js/ui/dnd.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/dnd.js b/js/ui/dnd.js
index e27c3691fd..14ccb2af3a 100644
--- a/js/ui/dnd.js
+++ b/js/ui/dnd.js
@@ -704,8 +704,8 @@ var _Draggable = class _Draggable {
 
     _onAnimationComplete(dragActor, eventTime) {
         if (this._dragOrigParent) {
-            Main.uiGroup.remove_child(this._dragActor);
-            this._dragOrigParent.add_actor(this._dragActor);
+            Main.uiGroup.remove_child(dragActor);
+            this._dragOrigParent.add_actor(dragActor);
             dragActor.set_scale(this._dragOrigScale, this._dragOrigScale);
             dragActor.set_position(this._dragOrigX, this._dragOrigY);
         } else {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]