[gnome-shell/T27795: 113/138] search: Remove the "more" overlaid icon for search providers
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/T27795: 113/138] search: Remove the "more" overlaid icon for search providers
- Date: Tue, 1 Oct 2019 23:38:49 +0000 (UTC)
commit c02edb083c764f54f0deabb04240d1716a0bf0f1
Author: Mario Sanchez Prada <mario endlessm com>
Date: Tue Jun 20 21:22:14 2017 +0100
search: Remove the "more" overlaid icon for search providers
We didn't have this before and it's unclear whether it will
create confusion with our users, so remove it to keep the same
style we used to ship in the previous version of the shell.
https://phabricator.endlessm.com/T17659
js/ui/search.js | 28 ----------------------------
1 file changed, 28 deletions(-)
---
diff --git a/js/ui/search.js b/js/ui/search.js
index 2660b01e26..8008335362 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -224,9 +224,6 @@ var SearchResultsBase = class {
Main.overview.hide();
}
- _setMoreCount(_count) {
- }
-
_ensureResultActors(results, callback) {
let metasNeeded = results.filter(
resultId => this._resultDisplays[resultId] === undefined
@@ -280,7 +277,6 @@ var SearchResultsBase = class {
let results = maxResults > -1
? this.provider.filterResults(providerResults, maxResults)
: providerResults;
- let moreCount = Math.max(providerResults.length - results.length, 0);
this._ensureResultActors(results, successful => {
if (!successful) {
@@ -297,7 +293,6 @@ var SearchResultsBase = class {
results.forEach(resultId => {
this._addItem(this._resultDisplays[resultId]);
});
- this._setMoreCount(this.provider.canLaunchSearch ? moreCount : 0);
this.actor.show();
callback();
});
@@ -332,10 +327,6 @@ var ListSearchResults = class extends SearchResultsBase {
this._resultDisplayBin.set_child(this._container);
}
- _setMoreCount(count) {
- this.providerInfo.setMoreCount(count);
- }
-
_getMaxDisplayedResults() {
return MAX_LIST_SEARCH_RESULTS_ROWS;
}
@@ -874,22 +865,8 @@ class ProviderInfo extends St.Button {
let icon = new St.Icon({ icon_size: this.PROVIDER_ICON_SIZE,
gicon: provider.appInfo.get_icon() });
- let detailsBox = new St.BoxLayout({ style_class: 'list-search-provider-details',
- vertical: true,
- x_expand: true });
-
- let nameLabel = new St.Label({ text: provider.appInfo.get_name(),
- x_align: Clutter.ActorAlign.START });
-
- this._moreLabel = new St.Label({ x_align: Clutter.ActorAlign.START });
-
- detailsBox.add_actor(nameLabel);
- detailsBox.add_actor(this._moreLabel);
-
-
this._content = new St.Widget({ layout_manager: new Clutter.BinLayout() });
this._content.add_actor(icon);
- this._content.add_actor(detailsBox);
let box = new St.BoxLayout({ vertical: true, x_expand: false });
this.set_child(box);
@@ -911,9 +888,4 @@ class ProviderInfo extends St.Button {
if (app.state == Shell.AppState.STOPPED)
IconGrid.zoomOutActor(this._content);
}
-
- setMoreCount(count) {
- this._moreLabel.text = ngettext("%d more", "%d more", count).format(count);
- this._moreLabel.visible = count > 0;
- }
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]