[nautilus/wip/oholy/properties-window-critical-fix: 13/16] properties-window: Fix criticals when closing



commit 6e1576e62cd344af3c9e0322111699a2ac78281f
Author: Ondrej Holy <oholy redhat com>
Date:   Tue Sep 24 17:06:15 2019 +0200

    properties-window: Fix criticals when closing
    
    The "eel_timed_wait_stop: assertion 'wait != NULL' failed" critical
    is printed when closing the properties window since commit c8c2fab2.
    This is because the timed wait has been already removed. Let's remove
    the wait when closing only if it has not been yet removed in order to
    prevent this criticals.
    
    Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/1075

 src/nautilus-properties-window.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
index 9d9bd1c54..969e3ffea 100644
--- a/src/nautilus-properties-window.c
+++ b/src/nautilus-properties-window.c
@@ -5240,7 +5240,7 @@ properties_window_finish (StartupData *data)
                                               data);
     }
 
-    remove_pending (data, TRUE, TRUE, FALSE);
+    remove_pending (data, TRUE, (data->window == NULL), FALSE);
     startup_data_free (data);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]