[gimp] libgimp: reduce GObject Introspection warnings.
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] libgimp: reduce GObject Introspection warnings.
- Date: Thu, 10 Oct 2019 10:32:18 +0000 (UTC)
commit 8cf4b7a43a3aa5424e513898ab207ad1460d464f
Author: Jehan <jehan girinstud io>
Date: Thu Oct 10 12:26:26 2019 +0200
libgimp: reduce GObject Introspection warnings.
Thanks to Massimo for helping:
> To reduce the number of warnings down to 2, it is necessary to list
> gimptypes.h and gimpenums.h right after gimp.h and gimpui.h
> gimpuitypes.h at the start of libgimpui_headers_introspectable like
> they are in the corresponding list in Makefile.gi.
>
> Their order evidently matters
See #4018.
Some stuff are still wrong, but this is a first step in the right
direction.
libgimp/meson.build | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
---
diff --git a/libgimp/meson.build b/libgimp/meson.build
index 3ef9085edf..7606eb8a92 100644
--- a/libgimp/meson.build
+++ b/libgimp/meson.build
@@ -182,12 +182,16 @@ libgimp_sources = [
]
libgimp_headers_introspectable = [
+ # Order matters. Leave these headers at the top.
'gimp.h',
+ 'gimptypes.h',
+ 'gimpenums.h',
+
+ # Other headers
'gimpbrushselect.h',
'gimpchannel.h',
'gimpdisplay.h',
'gimpdrawable.h',
- 'gimpenums.h',
'gimpfileprocedure.h',
'gimpfontselect.h',
'gimpgimprc.h',
@@ -209,7 +213,6 @@ libgimp_headers_introspectable = [
'gimpsaveprocedure.h',
'gimpselection.h',
'gimpthumbnailprocedure.h',
- 'gimptypes.h',
'gimpvectors.h',
pdb_wrappers_headers,
]
@@ -247,6 +250,11 @@ libgimpui_sources = [
]
libgimpui_headers_introspectable = [
+ # Order matters. Leave these headers at the top.
+ 'gimpui.h',
+ 'gimpuitypes.h',
+
+ # Other headers
'gimpaspectpreview.h',
'gimpbrushselectbutton.h',
'gimpdrawablepreview.h',
@@ -263,8 +271,6 @@ libgimpui_headers_introspectable = [
'gimpprocview.h',
'gimpprogressbar.h',
'gimpselectbutton.h',
- 'gimpui.h',
- 'gimpuitypes.h',
'gimpzoompreview.h',
]
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]