[mutter/wip/exalm/focused-appearance: 4/4] window: Appear as focused while focusing
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter/wip/exalm/focused-appearance: 4/4] window: Appear as focused while focusing
- Date: Sun, 13 Oct 2019 13:45:27 +0000 (UTC)
commit b32d2e3b6e10e1197fd8e6740d60d622eb18ae2e
Author: Alexander Mikhaylenko <exalm7659 gmail com>
Date: Sun Oct 13 05:15:51 2019 +0500
window: Appear as focused while focusing
Prevent focused window from blinking after switching to another
workspace on X11.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/850
src/core/window-private.h | 3 +++
src/core/window.c | 9 ++++++++-
2 files changed, 11 insertions(+), 1 deletion(-)
---
diff --git a/src/core/window-private.h b/src/core/window-private.h
index 4715c6692..4f3329bd2 100644
--- a/src/core/window-private.h
+++ b/src/core/window-private.h
@@ -540,6 +540,9 @@ struct _MetaWindow
int constrained_placement_rule_offset_y;
guint unmanage_idle_id;
+
+ /* Prevent blinking when focusing */
+ gboolean focusing;
};
struct _MetaWindowClass
diff --git a/src/core/window.c b/src/core/window.c
index 59d19f5b9..b3fda428c 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -4773,6 +4773,10 @@ meta_window_focus (MetaWindow *window,
window = modal_transient;
}
+ /* If the window was already appearing focused, but didn't have has_focus set,
+ * it will now briefly appear unfocused on X11. Set a flag to prevent that. */
+ window->focusing = TRUE;
+
meta_window_flush_calc_showing (window);
if ((!window->mapped || window->hidden) && !window->shaded)
@@ -4780,6 +4784,7 @@ meta_window_focus (MetaWindow *window,
meta_topic (META_DEBUG_FOCUS,
"Window %s is not showing, not focusing after all\n",
window->desc);
+ window->focusing = FALSE;
return;
}
@@ -5259,6 +5264,8 @@ meta_window_set_focused_internal (MetaWindow *window,
{
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
+ window->focusing = FALSE;
+
if (focused)
{
window->has_focus = TRUE;
@@ -7248,7 +7255,7 @@ meta_window_appears_focused (MetaWindow *window)
if (workspace && workspace != workspace_manager->active_workspace)
default_window = meta_workspace_get_default_focus_window (workspace);
- return window->has_focus || (window->attached_focus_window != NULL) || (window == default_window);
+ return window->has_focus || window->focusing || (window->attached_focus_window != NULL) || (window ==
default_window);
}
gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]