[gnome-shell/wip/hadess/always-launch-discrete-gpu: 4/6] ci: Phrase error in a way that gives a hint on how to fix problem
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/hadess/always-launch-discrete-gpu: 4/6] ci: Phrase error in a way that gives a hint on how to fix problem
- Date: Mon, 21 Oct 2019 11:23:56 +0000 (UTC)
commit 6b61d8b246940545d9f2ead83c9ae5a609bf7821
Author: Bastien Nocera <hadess hadess net>
Date: Mon Oct 21 13:06:25 2019 +0200
ci: Phrase error in a way that gives a hint on how to fix problem
The passive phrasing makes it sound like there's something inherently
broken with the commit, rather than simply being missing an annotation
that the author can add.
Closes: #1809
.gitlab-ci/check-commit-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/.gitlab-ci/check-commit-log.sh b/.gitlab-ci/check-commit-log.sh
index cc3bcee602..cbc48368b2 100755
--- a/.gitlab-ci/check-commit-log.sh
+++ b/.gitlab-ci/check-commit-log.sh
@@ -25,7 +25,7 @@ function commit_message_has_url() {
for commit in $commits; do
if ! commit_message_has_url $commit; then
- echo "Missing merge request or issue URL on commit $(echo $commit | cut -c -8)"
+ echo "Commit $(echo $commit | cut -c -8) needs a merge request or issue URL"
exit 1
fi
done
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]