[gjs: 1/2] tests: Enable regression test cases for GPtrArrays and GArrays of structures
- From: Philip Chimento <pchimento src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs: 1/2] tests: Enable regression test cases for GPtrArrays and GArrays of structures
- Date: Mon, 2 Sep 2019 07:20:26 +0000 (UTC)
commit 28fd0519a0873f29d547efeb4db0ce5d84354c54
Author: Stéphane Seng <seng stephane gmail com>
Date: Mon Sep 2 07:20:11 2019 +0000
tests: Enable regression test cases for GPtrArrays and GArrays of structures
Enable the temporarily disabled tests added in !311 because the then missing
gobject-introspection additional test cases from gobject-introspection!160 have
been released in https://gitlab.gnome.org/GNOME/gobject-introspection/-/tags/1.61.1.
The gobject-introspection-1.0 version constraint has been updated to 1.61.2
instead of 1.61.1 because the test case added in !328 triggers a segfault
with the 1.61.1 release.
This segfault does not occur after gobject-introspection!171 which is included
in https://gitlab.gnome.org/GNOME/gobject-introspection/-/tags/1.61.2.
See https://gitlab.gnome.org/GNOME/gobject-introspection/blob/1.61.2/NEWS#L22
and https://gitlab.gnome.org/GNOME/gobject-introspection/blob/1.61.2/NEWS#L5.
configure.ac | 2 +-
installed-tests/js/testGIMarshalling.js | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 6ecb3281..3d42e0ac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -372,7 +372,7 @@ AC_CONFIG_LINKS([
AC_OUTPUT
# Warn about conditions that affect runtime
-PKG_CHECK_EXISTS([gobject-introspection-1.0 >= 1.59.2], [], [
+PKG_CHECK_EXISTS([gobject-introspection-1.0 >= 1.61.2], [], [
AC_MSG_WARN([You do not have a new enough version of
gobject-introspection to run the tests. You can still build GJS, but some
tests will fail.])])
diff --git a/installed-tests/js/testGIMarshalling.js b/installed-tests/js/testGIMarshalling.js
index a10d8fda..17c09333 100644
--- a/installed-tests/js/testGIMarshalling.js
+++ b/installed-tests/js/testGIMarshalling.js
@@ -535,10 +535,10 @@ describe('GArray', function () {
}).pend('https://gitlab.gnome.org/GNOME/gjs/issues/106');
});
- xit('marshals boxed structs as a transfer-full return value', function () {
+ it('marshals boxed structs as a transfer-full return value', function () {
expect(GIMarshallingTests.garray_boxed_struct_full_return().map(e => e.long_))
.toEqual([42, 43, 44]);
- }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/160');
+ });
describe('of booleans with transfer none', function () {
testInParameter('garray_bool_none', [-1, 0, 1, 2]);
@@ -560,10 +560,10 @@ describe('GPtrArray', function () {
});
describe('of structs', function () {
- xit('can be returned with transfer full', function () {
+ it('can be returned with transfer full', function () {
expect(GIMarshallingTests.gptrarray_boxed_struct_full_return().map(e => e.long_))
.toEqual([42, 43, 44]);
- }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/160');
+ });
});
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]