[polari] Revert "ci: Import run-eslint script from gnome-shell"
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] Revert "ci: Import run-eslint script from gnome-shell"
- Date: Thu, 12 Sep 2019 13:28:44 +0000 (UTC)
commit 2399228d61de834e18cc21f6c1fb0dda0b74bb3e
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Sep 12 15:26:41 2019 +0200
Revert "ci: Import run-eslint script from gnome-shell"
Filtering errors by changed lines in a merge request means some
errors can slip through, for example when an import becomes unused
but isn't removed.
That's more common than rules changing behind our back, so revert
to running eslint directly again.
.gitlab-ci.yml | 5 ++--
.gitlab-ci/run-eslint.sh | 78 ------------------------------------------------
2 files changed, 3 insertions(+), 80 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a2c1d0d..1e40047 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -8,6 +8,7 @@ stages:
variables:
BUNDLE: "polari-git.flatpak"
+ LINT_LOG: "eslint-report.txt"
.only_default: &only_default
only:
@@ -27,11 +28,11 @@ eslint:
image: registry.gitlab.gnome.org/gnome/gjs:fedora.static-analysis
stage: source_check
script:
- - ./.gitlab-ci/run-eslint.sh
+ - eslint -o $LINT_LOG --no-color src || { cat $LINT_LOG; false; }
<<: *only_default
artifacts:
paths:
- - reports
+ - ${LINT_LOG}
when: on_failure
flatpak:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]