[glib: 3/7] tests: Fix a couple of static analysis warnings in autoptr tests
- From: Nirbheek Chauhan <nirbheekc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib: 3/7] tests: Fix a couple of static analysis warnings in autoptr tests
- Date: Fri, 13 Sep 2019 12:38:02 +0000 (UTC)
commit df647a583d2008f6d0514bcfe505fb0ad8a25cb8
Author: Philip Withnall <withnall endlessm com>
Date: Thu Sep 5 14:13:51 2019 +0100
tests: Fix a couple of static analysis warnings in autoptr tests
The static analyser can’t yet work out how `g_autofree` works, so
disable those tests.
Signed-off-by: Philip Withnall <withnall endlessm com>
Helps: #1767
glib/tests/autoptr.c | 7 +++++++
gobject/tests/autoptr.c | 3 +++
2 files changed, 10 insertions(+)
---
diff --git a/glib/tests/autoptr.c b/glib/tests/autoptr.c
index fccdfe55e..4eed862af 100644
--- a/glib/tests/autoptr.c
+++ b/glib/tests/autoptr.c
@@ -10,6 +10,9 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(HasNonVoidCleanup, non_void_cleanup)
static void
test_autofree (void)
{
+#ifdef __clang_analyzer__
+ g_test_skip ("autofree tests aren’t understood by the clang analyser");
+#else
g_autofree gchar *p = NULL;
g_autofree gchar *p2 = NULL;
g_autofree gchar *alwaysnull = NULL;
@@ -35,6 +38,7 @@ test_autofree (void)
}
g_assert_null (alwaysnull);
+#endif /* __clang_analyzer__ */
}
static void
@@ -592,6 +596,9 @@ test_autolist (void)
l = g_list_prepend (l, b1);
l = g_list_prepend (l, b3);
+
+ /* Squash warnings about dead stores */
+ (void) l;
}
/* Only assert if autoptr works */
diff --git a/gobject/tests/autoptr.c b/gobject/tests/autoptr.c
index cf7687d84..1f68cb3f9 100644
--- a/gobject/tests/autoptr.c
+++ b/gobject/tests/autoptr.c
@@ -113,6 +113,9 @@ test_autolist (void)
l = g_list_prepend (l, tac1);
l = g_list_prepend (l, tac2);
+
+ /* Squash warnings about dead stores */
+ (void) l;
}
/* Only assert if autoptr works */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]