[gnome-shell-extensions] Revert "ci: Import run-eslint script from gnome-shell"
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-extensions] Revert "ci: Import run-eslint script from gnome-shell"
- Date: Fri, 13 Sep 2019 23:56:52 +0000 (UTC)
commit ecf608ead8185f2e4cf0142a8e591377bc149d9d
Author: Florian Müllner <fmuellner gnome org>
Date: Sat Sep 14 01:55:58 2019 +0200
Revert "ci: Import run-eslint script from gnome-shell"
Filtering errors by changed lines in a merge request means some
errors can slip through, for example when an import becomes unused
but isn't removed.
That's more common than rules changing behind our back, so revert
to running eslint directly again.
This reverts commit 119da3291bc149d14acf4a30e261a97ae55ab1f0.
.gitlab-ci.yml | 7 +++--
.gitlab-ci/run-eslint.sh | 78 ------------------------------------------------
2 files changed, 5 insertions(+), 80 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b008266..8f6b13a 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -3,6 +3,9 @@ stages:
- source_check
- build
+variables:
+ LINT_LOG: "eslint-report.txt"
+
.only_default: &only_default
only:
- branches
@@ -21,11 +24,11 @@ eslint:
image: registry.gitlab.gnome.org/gnome/gnome-shell/extension-ci:v1
stage: source_check
script:
- - ./.gitlab-ci/run-eslint.sh
+ - eslint -o $LINT_LOG --no-color || { cat $LINT_LOG; false; }
<<: *only_default
artifacts:
paths:
- - reports
+ - ${LINT_LOG}
when: on_failure
build-shell-extensions:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]